Skip to content

Conversation

@matejvasek
Copy link
Contributor

Use k8s primitives pod/svc/ingress instead of knative service.

@matejvasek matejvasek requested a review from jrangelramos July 8, 2025 15:41
@knative-prow knative-prow bot requested review from dsimansk and nainaz July 8, 2025 15:41
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2025
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.69%. Comparing base (589bbe8) to head (941eece).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2926      +/-   ##
==========================================
+ Coverage   59.95%   60.69%   +0.73%     
==========================================
  Files         130      130              
  Lines       16604    16604              
==========================================
+ Hits         9955    10077     +122     
+ Misses       5723     5571     -152     
- Partials      926      956      +30     
Flag Coverage Δ
e2e-tests 41.72% <ø> (+1.37%) ⬆️
integration-tests 55.37% <ø> (+1.72%) ⬆️
unit-tests 47.42% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

cc @jrangelramos

@matejvasek matejvasek marked this pull request as draft July 9, 2025 11:37
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2025
@matejvasek matejvasek requested a review from jrangelramos July 10, 2025 21:54
@matejvasek matejvasek marked this pull request as ready for review July 10, 2025 22:14
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2025
@matejvasek matejvasek requested review from gauron99 and lkingland and removed request for dsimansk and nainaz July 11, 2025 10:51
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Use k8s primitives pod/svc/ingress instead of knative service.

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@matejvasek matejvasek requested a review from lkingland July 11, 2025 18:24
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @jrangelramos

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@knative-prow knative-prow bot merged commit 30315ea into knative:main Jul 11, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants