Skip to content

Conversation

@KapilSareen
Copy link
Contributor

Changes

  • No particular changes. Just breaking the mcp pkg into files for easy maintainability.

@knative-prow knative-prow bot requested review from nainaz and vyasgun July 9, 2025 01:15
@knative-prow
Copy link

knative-prow bot commented Jul 9, 2025

Hi @KapilSareen. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 9, 2025
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 349 lines in your changes missing coverage. Please review.

Project coverage is 60.69%. Comparing base (e3759ec) to head (c42a830).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mcp/tools.go 0.00% 286 Missing ⚠️
pkg/mcp/help.go 0.00% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2928      +/-   ##
==========================================
+ Coverage   59.93%   60.69%   +0.75%     
==========================================
  Files         130      132       +2     
  Lines       16604    16604              
==========================================
+ Hits         9952    10077     +125     
+ Misses       5725     5571     -154     
- Partials      927      956      +29     
Flag Coverage Δ
e2e-tests 41.72% <0.00%> (+1.37%) ⬆️
integration-tests 55.34% <0.00%> (+1.72%) ⬆️
unit-tests 47.42% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KapilSareen, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@knative-prow knative-prow bot merged commit f096936 into knative:main Jul 14, 2025
59 of 63 checks passed
@KapilSareen KapilSareen deleted the refactor branch July 14, 2025 10:03
matejvasek pushed a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 6, 2025
matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 6, 2025
* mcp: adds func mcp command (knative#2836)

Signed-off-by: KapilSareen <[email protected]>

* mcp: adds create and deploy tools (knative#2859)

Signed-off-by: kapil <[email protected]>

* mcp: adds list tool (knative#2861)

Signed-off-by: kapil <[email protected]>

* mcp: adds build tool (knative#2865)

Signed-off-by: kapil <[email protected]>

* mcp: adds resource provider and prompt for root cmd docs (knative#2875)

Signed-off-by: kapil <[email protected]>

* mcp: adds delete tool and adds remote flag to deploy tool (knative#2863)

* rebases

* adds remote flag to deploy tool

Signed-off-by: kapil <[email protected]>

---------

Signed-off-by: kapil <[email protected]>

* mcp: extends flags support for existing tools (knative#2889)

Signed-off-by: kapil <[email protected]>

* mcp: adds resources and prompts for func subcommands (knative#2890)

Signed-off-by: kapil <[email protected]>

* mcp: adds tool and resource for config volumes (knative#2925)

Signed-off-by: kapil <[email protected]>

* mcp: refactors pkg for easy maintainability (knative#2928)

Signed-off-by: kapil <[email protected]>

* mcp: adds labels and envs config tools and resources (knative#2931)

Signed-off-by: kapil <[email protected]>

* mcp: adds remote template support (knative#2951)

Signed-off-by: kapil <[email protected]>

---------

Signed-off-by: KapilSareen <[email protected]>
Signed-off-by: kapil <[email protected]>
Co-authored-by: Kapil Sareen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants