Update tekton

[matejvasek]

Changes

• Update tekton to v1.1.0 in testing cluster (also updated PaC)
• Fixed yaml errors by adding quotes around variables that expand to an empty string. Older version of tekton was more permissive as it accepted broken yaml.
• Fixed image reference gcr.io => ghcr.io, we still use the older rootfull task that refers gcr.io not ghcr.io like the latest tasks.

[knative-prow]

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.69%. Comparing base (7799a69) to head (2fe71e6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
+ Coverage   57.14%   60.69%   +3.54%     
==========================================
  Files         130      130              
  Lines       16604    16604              
==========================================
+ Hits         9488    10077     +589     
+ Misses       6223     5571     -652     
- Partials      893      956      +63     

Flag	Coverage Δ
e2e-tests	41.72% <ø> (+10.70%)	⬆️
integration-tests	55.34% <ø> (+1.70%)	⬆️
unit-tests	47.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[matejvasek]

PTAL @jrangelramos @gauron99

[gauron99]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ryan-alexander-zhang]

The tekton need the sa permission to operate the knative resources. The sa is default.
spec:
taskRunTemplate:
serviceAccountName: sa-1
taskRunSpecs:
- pipelineTaskName: build-task
serviceAccountName: sa-for-build
Looks like there's no taskRunTemplate param. Can you help to fix the issue? Thanks.
https://tekton.dev/docs/pipelines/pipelineruns/#specifying-custom-serviceaccount-credentials

[matejvasek]

The tekton need the sa permission to operate the knative resources. The sa is default. spec: taskRunTemplate: serviceAccountName: sa-1 taskRunSpecs: - pipelineTaskName: build-task serviceAccountName: sa-for-build Looks like there's no taskRunTemplate param. Can you help to fix the issue? Thanks. https://tekton.dev/docs/pipelines/pipelineruns/#specifying-custom-serviceaccount-credentials

https://github.com/knative/func/blob/main/hack/allocate.sh#L413
maybe?

[ryan-alexander-zhang]

The tekton need the sa permission to operate the knative resources. The sa is default. spec: taskRunTemplate: serviceAccountName: sa-1 taskRunSpecs: - pipelineTaskName: build-task serviceAccountName: sa-for-build Looks like there's no taskRunTemplate param. Can you help to fix the issue? Thanks. https://tekton.dev/docs/pipelines/pipelineruns/#specifying-custom-serviceaccount-credentials

https://github.com/knative/func/blob/main/hack/allocate.sh#L413 maybe?

Thank you for your reply.

It's a solution to bind the role to the default sa. But I’m confused. I’ve already set the service account with the necessary permissions for Knative resources using the func CLI, but I still got the error.

For example: deploy --git-url=xxx -n ronghuanz --remote --service-account=ronghuanz

Error: function pipeline run has failed with message: 

ERROR: cannont deploy the function: knative deployer failed to get the Knative Service: services.serving.knative.dev "func-test" is forbidden: User "system:serviceaccount:ronghuanz:default" cannot get resource "services" in API group "serving.knative.dev" in the namespace "ronghuanz"

[matejvasek]

I suspect that --service-account is not really implemented for --remote build.

[matejvasek]

Does deploy with --remote=0 work?

[matejvasek]

Please file bug report / feature request.