Skip to content

Conversation

@lkingland
Copy link
Member

@lkingland lkingland commented Jul 24, 2025

Fixes a mismatch in container file permissions, surfacing during local E2E testing when switching between local, remote, and builders.

$ func deploy --remote --builder=pack --registry=registry.default.svc.cluster.local:5000/func -v
  Error: cannot upload sources to the PVC: cannot start the pod: pod prematurely exited (output: "ERROR: cannot purge dest dir: unlinkat
  /tmp/volume_mnt/source/.s2i/bin/assemble: permission denied\n", exitcode: 1)
      e2e_test.go:1249: exit status 1

@knative-prow knative-prow bot requested review from jrangelramos and vyasgun July 24, 2025 04:36
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2025
@lkingland lkingland requested a review from matejvasek July 24, 2025 04:37
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.02%. Comparing base (0157893) to head (f59a423).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
+ Coverage   59.28%   60.02%   +0.74%     
==========================================
  Files         132      132              
  Lines       16835    16836       +1     
==========================================
+ Hits         9980    10106     +126     
+ Misses       5926     5772     -154     
- Partials      929      958      +29     
Flag Coverage Δ
e2e-tests 41.32% <100.00%> (+1.44%) ⬆️
integration-tests 54.80% <100.00%> (+1.70%) ⬆️
unit-tests 46.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Contributor

/lgtm
/approve
/hold for matej review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
@knative-prow
Copy link

knative-prow bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

/lgtm

@matejvasek
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@knative-prow knative-prow bot merged commit d04ff0a into knative:main Jul 24, 2025
39 of 40 checks passed
@lkingland lkingland deleted the fix-fs-permissions branch October 15, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants