-
Notifications
You must be signed in to change notification settings - Fork 173
cleanup: Simplify hack/ components #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I forgot to update the test itself, let me do that tomorrow |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2959 +/- ##
===========================================
- Coverage 58.27% 46.64% -11.64%
===========================================
Files 132 130 -2
Lines 16835 16828 -7
===========================================
- Hits 9811 7849 -1962
- Misses 6123 8274 +2151
+ Partials 901 705 -196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48910f7 to
3f7a568
Compare
|
OH I thought there is a GH token in the verify deps action but I guess not |
3f7a568 to
fcbd172
Compare
fcbd172 to
10bee7a
Compare
|
this has the same error as in #2954 (comment) |
|
/override ? |
|
@gauron99: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "E2E Test (ubuntu-24.04-arm, go)" |
|
@gauron99: Overrode contexts on behalf of gauron99: E2E Test (ubuntu-24.04-arm, go) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dsimansk can you PTAL if this looks good for the |
Sure, it seems to work as intended. |
|
/lgtm |
lkingland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
/hold until we can resolve Matej's question. We can discuss it on this week's call if that's easier.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
10bee7a to
1a73c29
Compare
4ce1958 to
20f0fcd
Compare
20f0fcd to
9b02484
Compare
9b02484 to
0d3167f
Compare
|
I wanted to update the name to PTAL |
- now runs in update-deps.sh - only need to modify json and autogen script
0d3167f to
c7cd471
Compare
|
The Codecov was showing not uploaded coverages against base, but also I wasnt rebased on main and was 8 commits behind. Rebasing to see if this helps. |
|
@lkingland @matejvasek LGTM pls |
|
/lgtm |
Simplify components kept up to date in
/hacknote: if a repo doesnt have owner/repo fields filled, dont auto-bump it
PS: tekton is not auto-updated because their release version fetched from github contains other text-string instead of just the clean "v" ... need to update the script
PSS: Will update the other scripts as I go (makefile w springboot/typescript bumps etc.)
fixes #2960