Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Jul 31, 2025

Simplify components kept up to date in /hack

  • now runs as part of update-deps.sh
  • only need to modify json and autogen script
  1. add/modify .json
    note: if a repo doesnt have owner/repo fields filled, dont auto-bump it
  2. add the autogenerated file
  3. celebrate with a beer

PS: tekton is not auto-updated because their release version fetched from github contains other text-string instead of just the clean "v" ... need to update the script
PSS: Will update the other scripts as I go (makefile w springboot/typescript bumps etc.)

fixes #2960

@knative-prow knative-prow bot requested review from jrangelramos and nainaz July 31, 2025 19:04
@gauron99 gauron99 requested review from matejvasek and removed request for jrangelramos and nainaz July 31, 2025 19:04
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 31, 2025
@gauron99 gauron99 requested a review from lkingland July 31, 2025 19:04
@gauron99
Copy link
Contributor Author

I forgot to update the test itself, let me do that tomorrow

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.64%. Comparing base (e06397d) to head (0d3167f).
⚠️ Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (e06397d) and HEAD (0d3167f). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (e06397d) HEAD (0d3167f)
unit-tests 3 0
integration-tests 1 0
e2e-tests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2959       +/-   ##
===========================================
- Coverage   58.27%   46.64%   -11.64%     
===========================================
  Files         132      130        -2     
  Lines       16835    16828        -7     
===========================================
- Hits         9811     7849     -1962     
- Misses       6123     8274     +2151     
+ Partials      901      705      -196     
Flag Coverage Δ
e2e-tests ?
integration-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch 2 times, most recently from 48910f7 to 3f7a568 Compare August 1, 2025 05:31
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 1, 2025

OH I thought there is a GH token in the verify deps action client without token interesting

but I guess not

@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch from 3f7a568 to fcbd172 Compare August 1, 2025 05:40
@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch from fcbd172 to 10bee7a Compare August 1, 2025 06:02
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 1, 2025

this has the same error as in #2954 (comment)
lets see if actually a flake

@gauron99
Copy link
Contributor Author

gauron99 commented Aug 1, 2025

/override ?

@knative-prow
Copy link

knative-prow bot commented Aug 1, 2025

@gauron99: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • E2E Test (ubuntu-24.04-arm, go)
  • EasyCLA
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor Author

gauron99 commented Aug 1, 2025

/override "E2E Test (ubuntu-24.04-arm, go)"

@knative-prow
Copy link

knative-prow bot commented Aug 1, 2025

@gauron99: Overrode contexts on behalf of gauron99: E2E Test (ubuntu-24.04-arm, go)

Details

In response to this:

/override "E2E Test (ubuntu-24.04-arm, go)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor Author

gauron99 commented Aug 1, 2025

@dsimansk can you PTAL if this looks good for the hack/update-deps.sh pls?

@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2025

@dsimansk can you PTAL if this looks good for the hack/update-deps.sh pls?

Sure, it seems to work as intended.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2025
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

/hold until we can resolve Matej's question. We can discuss it on this week's call if that's easier.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

/retest

1 similar comment
@matejvasek
Copy link
Contributor

/retest

@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch from 10bee7a to 1a73c29 Compare August 3, 2025 12:07
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2025
@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch 2 times, most recently from 4ce1958 to 20f0fcd Compare August 3, 2025 12:11
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2025
@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch from 20f0fcd to 9b02484 Compare August 3, 2025 12:15
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2025
@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch from 9b02484 to 0d3167f Compare August 3, 2025 12:17
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 3, 2025

I wanted to update the name to update-builder dir in hack/cmd but I see theres a conflict so let me not complicate things further :D

PTAL

- now runs in update-deps.sh
- only need to modify json and autogen script
@gauron99 gauron99 force-pushed the push-uptknsyyqtow branch from 0d3167f to c7cd471 Compare August 3, 2025 13:23
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 3, 2025

The Codecov was showing not uploaded coverages against base, but also I wasnt rebased on main and was 8 commits behind. Rebasing to see if this helps.

@lkingland lkingland removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2025
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 5, 2025

@lkingland @matejvasek LGTM pls

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2025
@knative-prow knative-prow bot merged commit 7fb68ef into knative:main Aug 5, 2025
38 checks passed
@gauron99 gauron99 deleted the push-uptknsyyqtow branch August 12, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve current components script

5 participants