Fix backward compat Python pack build #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XS
matejvasek
requested review from
gauron99 and
lkingland
and removed request for
jrangelramos and
nainaz
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
+ Coverage 58.30% 60.02% +1.71%
==========================================
Files 132 132
Lines 16836 16837 +1
==========================================
+ Hits 9816 10106 +290
+ Misses 6120 5773 -347
- Partials 900 958 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matejvasek
force-pushed
the
fix-backward-compat-build
branch
from
7ab2737 to
70bee9d
Compare
Signed-off-by: Matej Vašek <[email protected]>
matejvasek
force-pushed
the
fix-backward-compat-build
branch
from
70bee9d to
3f7deb5
Compare
lkingland
approved these changes
Aug 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Oct 14, 2025
picking knative#2962 Signed-off-by: Matej Vašek <[email protected]>
Merged
knative-prow bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Fix backward compat Python pack build picking #2962 Signed-off-by: Matej Vašek <[email protected]> * fix: Python host builder base image version picking #2965 Signed-off-by: Matej Vašek <[email protected]> * Remove container flag - variant I picking #2987 Signed-off-by: Matej Vašek <[email protected]> * fix python injector bug picking #2992 Signed-off-by: Matej Vašek <[email protected]> * fix-of-a-fix picking #2994 Signed-off-by: Matej Vašek <[email protected]> * fix: python scaffolding picking #3080 Signed-off-by: Matej Vašek <[email protected]> * fix: use python3 when python not presetn picking #3082 Signed-off-by: Matej Vašek <[email protected]> * dapr install upgrade picking #3055 Signed-off-by: David Fridrich <[email protected]> Co-authored-by: David Fridrich <[email protected]> Signed-off-by: Matej Vašek <[email protected]> * test: skip ipv6 test correctly picking #3076 Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> Signed-off-by: David Fridrich <[email protected]> Co-authored-by: David Fridrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
resolves #2956