-
Notifications
You must be signed in to change notification settings - Fork 173
pin knative.dev/pkg so that it compiles #2986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tektoncd uses an old metrics package we dropped. thus we need to wait for them to migrate away before resuming these bumps
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2986 +/- ##
==========================================
+ Coverage 57.96% 59.72% +1.75%
==========================================
Files 132 132
Lines 16944 16944
==========================================
+ Hits 9821 10119 +298
+ Misses 6222 5868 -354
- Partials 901 957 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We can bump the tekton we use I think |
|
tekton hasn't made the necessary changes yet |
|
This is a workaround to unblock knative dep updates |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tektoncd uses an old metrics package we dropped. thus we need to
wait for them to migrate away before resuming these bumps
For now we pin knative.dev/pkg