-
Notifications
You must be signed in to change notification settings - Fork 173
Cleanup: Remove container flag (var I) #2987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
+ Coverage 58.95% 59.60% +0.64%
==========================================
Files 132 132
Lines 16944 16919 -25
==========================================
+ Hits 9990 10085 +95
+ Misses 6025 5877 -148
- Partials 929 957 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5cb6745 to
3a5dbf3
Compare
lkingland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
picking knative#2987 Signed-off-by: Matej Vašek <[email protected]>
picking knative#2987 Signed-off-by: Matej Vašek <[email protected]>
* Fix backward compat Python pack build picking #2962 Signed-off-by: Matej Vašek <[email protected]> * fix: Python host builder base image version picking #2965 Signed-off-by: Matej Vašek <[email protected]> * Remove container flag - variant I picking #2987 Signed-off-by: Matej Vašek <[email protected]> * fix python injector bug picking #2992 Signed-off-by: Matej Vašek <[email protected]> * fix-of-a-fix picking #2994 Signed-off-by: Matej Vašek <[email protected]> * fix: python scaffolding picking #3080 Signed-off-by: Matej Vašek <[email protected]> * fix: use python3 when python not presetn picking #3082 Signed-off-by: Matej Vašek <[email protected]> * dapr install upgrade picking #3055 Signed-off-by: David Fridrich <[email protected]> Co-authored-by: David Fridrich <[email protected]> Signed-off-by: Matej Vašek <[email protected]> * test: skip ipv6 test correctly picking #3076 Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> Signed-off-by: David Fridrich <[email protected]> Co-authored-by: David Fridrich <[email protected]>
Variant I
--builder=hostfor all languages to use it.Changes
--containerflag forfunc runfunc run/kind cleanup
Fixes #2973
Release notes
Docs