fix: use temp directory in creds tests to prevent auth.json pollution #3311

Kunal1522 · 2025-12-20T13:35:12Z

Fixes #3158
When HOME is empty during tests, testConfigPath now falls back to t.TempDir() instead of returning an empty string. This prevents auth.json from being created in the pkg/creds/ directory.

Fixes knative#3158 When HOME is empty during tests, testConfigPath now falls back to t.TempDir() instead of returning an empty string. This prevents auth.json from being created in the pkg/creds/ directory.

knative-prow · 2025-12-20T13:35:20Z

Welcome @Kunal1522! It looks like this is your first PR to knative/func 🎉

knative-prow · 2025-12-20T13:35:21Z

Hi @Kunal1522. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gauron99 · 2025-12-20T17:12:19Z

/ok-to-test

gauron99 · 2025-12-20T17:12:43Z

Hi @Kunal1522 does this also fix the pkg/oci/testdata/test-links/absoluteLink* created files issue?

codecov · 2025-12-20T17:19:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.05%. Comparing base (cf46238) to head (463b2eb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3311      +/-   ##
==========================================
- Coverage   55.09%   55.05%   -0.05%     
==========================================
  Files         170      170              
  Lines       19851    19851              
==========================================
- Hits        10937    10929       -8     
- Misses       7845     7853       +8     
  Partials     1069     1069

Flag	Coverage Δ
e2e	`39.59% <ø> (-0.01%)`	⬇️
e2e go	`35.62% <ø> (ø)`
e2e node	`31.13% <ø> (ø)`
e2e python	`35.27% <ø> (-0.09%)`	⬇️
e2e quarkus	`31.28% <ø> (ø)`
e2e rust	`30.72% <ø> (-0.03%)`	⬇️
e2e springboot	`30.77% <ø> (ø)`
e2e typescript	`31.25% <ø> (ø)`
integration	`17.49% <ø> (+0.03%)`	⬆️
unit macos-14	`44.96% <ø> (ø)`
unit macos-latest	`44.96% <ø> (ø)`
unit ubuntu-24.04-arm	`45.07% <ø> (ø)`
unit ubuntu-latest	`45.86% <ø> (ø)`
unit windows-latest	`44.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Kunal1522 · 2025-12-20T19:53:47Z

Hi @gauron99 i think absoluteLink* files were already fixed in #3223 because of which on testing this does not appear

Kunal1522 · 2025-12-20T20:00:50Z

however i am not sure why E2E - Runtimes (python) fails ?looks unrelated to my changes

gauron99 · 2025-12-21T07:11:15Z

Hi @gauron99 i think absoluteLink* files were already fixed in #3223 because of which on testing this does not appear

Ok great, its just not marked in the issue then, i will update it.

gauron99 · 2025-12-21T07:15:46Z

however i am not sure why E2E - Runtimes (python) fails ?looks unrelated to my changes

that mightve been a flake, I wasnt able to see them because of new changes. I reran the tests again

gauron99

/lgtm
Thanks for the contribution!

knative-prow · 2025-12-21T07:32:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, Kunal1522

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gauron99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gauron99 · 2025-12-21T07:33:36Z

/hold

gauron99 · 2025-12-21T07:34:34Z

One more thing @Kunal1522 . Could you please remove the TODO in .gitignore with that file path for pkg/creds/auth.json? we dont need to ignore it anymore with your change

Sorry to approve and then ask for changes, i remembered too late we have that in gitignore still

Feel free to ping me again so i can reapprove

Since the test now uses a temp directory, auth.json is no longer created in pkg/creds/, so we don't need to ignore it anymore.

Kunal1522 · 2025-12-21T08:46:37Z

Done @gauron99 Ready for re-review when you get a chance. Thanks!

gauron99 · 2025-12-21T09:26:40Z

thanks!

/lgtm
/unhold

fix: use temp directory in creds tests to prevent auth.json pollution

72a3b3d

Fixes knative#3158 When HOME is empty during tests, testConfigPath now falls back to t.TempDir() instead of returning an empty string. This prevents auth.json from being created in the pkg/creds/ directory.

knative-prow bot requested review from dsimansk and jrangelramos December 20, 2025 13:35

knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 20, 2025

knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2025

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2025

chore: trigger CI re-run

398c488

gauron99 approved these changes Dec 21, 2025

View reviewed changes

knative-prow bot assigned gauron99 Dec 21, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2025

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2025

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2025

chore: remove auth.json from .gitignore

463b2eb

Since the test now uses a temp directory, auth.json is no longer created in pkg/creds/, so we don't need to ignore it anymore.

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2025

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2025

knative-prow bot merged commit ba53524 into knative:main Dec 21, 2025
43 checks passed

Kunal1522 deleted the fix-auth-json-pollution branch December 21, 2025 09:56

fix: use temp directory in creds tests to prevent auth.json pollution #3311

fix: use temp directory in creds tests to prevent auth.json pollution #3311

Uh oh!

Conversation

Kunal1522 commented Dec 20, 2025

Uh oh!

knative-prow bot commented Dec 20, 2025

Uh oh!

knative-prow bot commented Dec 20, 2025

Uh oh!

gauron99 commented Dec 20, 2025

Uh oh!

gauron99 commented Dec 20, 2025

Uh oh!

codecov bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Kunal1522 commented Dec 20, 2025

Uh oh!

Kunal1522 commented Dec 20, 2025

Uh oh!

gauron99 commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gauron99 commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gauron99 left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Dec 21, 2025

Uh oh!

gauron99 commented Dec 21, 2025

Uh oh!

gauron99 commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kunal1522 commented Dec 21, 2025

Uh oh!

gauron99 commented Dec 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 20, 2025 •

edited

Loading

gauron99 commented Dec 21, 2025 •

edited

Loading

gauron99 commented Dec 21, 2025 •

edited

Loading

gauron99 commented Dec 21, 2025 •

edited

Loading