Skip to content

Ignore eventing error, when eventing is not installed#3428

Open
creydr wants to merge 1 commit intoknative:mainfrom
creydr:ignore-error-when-eventing-is-not-installed
Open

Ignore eventing error, when eventing is not installed#3428
creydr wants to merge 1 commit intoknative:mainfrom
creydr:ignore-error-when-eventing-is-not-installed

Conversation

@creydr
Copy link
Member

@creydr creydr commented Feb 9, 2026

Fixes #3404

Changes

  • 🧹 Ignore error about missing Knative Eventing installation on func deploy when Eventing is not required (when the user defined subscriptions for a Function and Eventing would not be installed, then an error of course is still raised)

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: creydr
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.59%. Comparing base (f75c581) to head (0c73f40).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/k8s/deployer.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
- Coverage   54.62%   54.59%   -0.03%     
==========================================
  Files         179      179              
  Lines       20228    20231       +3     
==========================================
- Hits        11049    11045       -4     
- Misses       8009     8014       +5     
- Partials     1170     1172       +2     
Flag Coverage Δ
e2e 38.56% <0.00%> (-0.01%) ⬇️
e2e go 32.75% <0.00%> (-0.01%) ⬇️
e2e node 28.65% <0.00%> (-0.01%) ⬇️
e2e python 32.26% <0.00%> (+0.01%) ⬆️
e2e quarkus 28.80% <0.00%> (-0.01%) ⬇️
e2e rust 28.21% <0.00%> (-0.01%) ⬇️
e2e springboot 26.66% <0.00%> (-0.01%) ⬇️
e2e typescript 28.76% <0.00%> (-0.01%) ⬇️
integration 17.55% <0.00%> (-0.05%) ⬇️
unit macos-14 42.27% <0.00%> (-0.01%) ⬇️
unit macos-latest 42.27% <0.00%> (-0.01%) ⬇️
unit ubuntu-24.04-arm 42.60% <0.00%> (-0.01%) ⬇️
unit ubuntu-latest 43.16% <0.00%> (-0.01%) ⬇️
unit windows-latest 42.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes raw deployer requires knative

1 participant