Skip to content

Fix Istio setup#2012

Closed
skonto wants to merge 1 commit intoknative:mainfrom
skonto:fix_istio
Closed

Fix Istio setup#2012
skonto wants to merge 1 commit intoknative:mainfrom
skonto:fix_istio

Conversation

@skonto
Copy link
Copy Markdown
Contributor

@skonto skonto commented Mar 6, 2025

Fixes #

Proposed Changes

@knative-prow knative-prow bot requested review from aliok and matzew March 6, 2025 14:42
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (2f4a10f) to head (b54081f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2012   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files          54       54           
  Lines        2622     2622           
=======================================
  Hits         1675     1675           
  Misses        830      830           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skonto
Copy link
Copy Markdown
Contributor Author

skonto commented Mar 6, 2025

Verify should be fixed with #2011

@skonto
Copy link
Copy Markdown
Contributor Author

skonto commented Mar 6, 2025

cc @houshengbo

@matzew matzew mentioned this pull request Mar 7, 2025
@skonto skonto closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant