Skip to content

Comments

[release-1.18] Updated the hack lib to the lastest#2182

Closed
houshengbo wants to merge 1 commit intoknative:release-1.18from
houshengbo:pull-hack-18
Closed

[release-1.18] Updated the hack lib to the lastest#2182
houshengbo wants to merge 1 commit intoknative:release-1.18from
houshengbo:pull-hack-18

Conversation

@houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Oct 23, 2025

The auto release job for 1.18 has run into the issue

Command '__unit_test_runner_for_module' failed in module /home/prow/go/src/knative.dev/serving: 1
Step failed: default_unit_test_runner

This PR pulled the latest hack script to fix it.

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2025
@knative-prow knative-prow bot requested review from aliok and matzew October 23, 2025 19:51
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.31%. Comparing base (d82e543) to head (c150c04).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.18    #2182      +/-   ##
================================================
+ Coverage         62.16%   63.31%   +1.14%     
================================================
  Files                49       49              
  Lines              2318     1878     -440     
================================================
- Hits               1441     1189     -252     
+ Misses              785      597     -188     
  Partials             92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

@houshengbo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eventing-upgrade-tests_operator_release-1.18 c150c04 link true /test eventing-upgrade-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dprotaso
Copy link
Member

This has chages from hack@main not hack@release-1.18

I had knobots make a PR here - #2183

@dprotaso dprotaso closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants