Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 26, 2025

@knative-prow
Copy link

knative-prow bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto November 26, 2025 22:14
@dprotaso
Copy link
Member Author

/assign @linkvt @nader-ziada

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.06%. Comparing base (f947d73) to head (729827b).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/nscert/config/store.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16272      +/-   ##
==========================================
- Coverage   80.07%   80.06%   -0.02%     
==========================================
  Files         215      215              
  Lines       13327    13327              
==========================================
- Hits        10672    10670       -2     
+ Misses       2297     2295       -2     
- Partials      358      362       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2025
@linkvt
Copy link
Contributor

linkvt commented Nov 27, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow knative-prow bot merged commit a38ad8f into knative:main Nov 27, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants