Skip to content

Migrate autoscaler stat forwarder to use EndpointSlices#16448

Open
dprotaso wants to merge 5 commits intoknative:mainfrom
dprotaso:migrate-to-endpointslice
Open

Migrate autoscaler stat forwarder to use EndpointSlices#16448
dprotaso wants to merge 5 commits intoknative:mainfrom
dprotaso:migrate-to-endpointslice

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Mar 11, 2026

Part of #7701

  • switch autoscaler stat forwarder to use endpoint slices
  • Cleanup older autoscaler endpoints
Autoscaler will now create EndpointSlices instead of Endpoints to perform lease based stat forwarding

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2026
@knative-prow
Copy link

knative-prow bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2026
@knative-prow knative-prow bot requested review from dsimansk and skonto March 11, 2026 00:52
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.14%. Comparing base (56af9d4) to head (85133f4).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cleanup/cmd/cleanup/cleanup.go 0.00% 8 Missing ⚠️
pkg/autoscaler/statforwarder/leases.go 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16448      +/-   ##
==========================================
- Coverage   80.21%   80.14%   -0.07%     
==========================================
  Files         217      217              
  Lines       13520    13533      +13     
==========================================
+ Hits        10845    10846       +1     
- Misses       2307     2320      +13     
+ Partials      368      367       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member Author

/retest

@dprotaso
Copy link
Member Author

/hold cancel
/assign @linkvt

@dprotaso dprotaso changed the title [wip] migrate autoscaler stat forwarder to use endpointslices Migrate autoscaler stat forwarder to use endpointslices Mar 11, 2026
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
@dprotaso
Copy link
Member Author

There's an issue with a assertion

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2026
@dprotaso dprotaso force-pushed the migrate-to-endpointslice branch from fe419a4 to 8fa8b16 Compare March 12, 2026 19:29
@dprotaso
Copy link
Member Author

I'm pulling the test changes to a separate PR

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2026
@dprotaso dprotaso changed the title Migrate autoscaler stat forwarder to use endpointslices Migrate autoscaler stat forwarder to use EndpointSlices Mar 12, 2026
Comment on lines 27 to 29
- apiGroups: [""]
resources: ["endpoints/restricted"] # Permission for RestrictedEndpointsAdmission
verbs: ["create"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add an equivalent rule for endpointslices? I read that this is openshift specific but maybe nevertheless good to keep it consistent with the endpoints logic.

Copy link
Member Author

@dprotaso dprotaso Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the equivalent is for OpenShift - or if this is still a thing that OpenShift needs.

Can you confirm and make changes in a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants