Migrate autoscaler stat forwarder to use EndpointSlices#16448
Migrate autoscaler stat forwarder to use EndpointSlices#16448dprotaso wants to merge 5 commits intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16448 +/- ##
==========================================
- Coverage 80.21% 80.14% -0.07%
==========================================
Files 217 217
Lines 13520 13533 +13
==========================================
+ Hits 10845 10846 +1
- Misses 2307 2320 +13
+ Partials 368 367 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
/hold cancel |
|
There's an issue with a assertion /hold |
Delete the custom endpoints the autoscaler creates since we now use EndpointSlices
fe419a4 to
8fa8b16
Compare
|
I'm pulling the test changes to a separate PR /hold cancel |
| - apiGroups: [""] | ||
| resources: ["endpoints/restricted"] # Permission for RestrictedEndpointsAdmission | ||
| verbs: ["create"] |
There was a problem hiding this comment.
Do we need to add an equivalent rule for endpointslices? I read that this is openshift specific but maybe nevertheless good to keep it consistent with the endpoints logic.
There was a problem hiding this comment.
I don't know what the equivalent is for OpenShift - or if this is still a thing that OpenShift needs.
Can you confirm and make changes in a follow up PR.
Part of #7701