Skip to content

Switch e2e testing assertions to use EndpointSlices#16454

Open
dprotaso wants to merge 4 commits intoknative:mainfrom
dprotaso:migrate-endpointslice-e2e
Open

Switch e2e testing assertions to use EndpointSlices#16454
dprotaso wants to merge 4 commits intoknative:mainfrom
dprotaso:migrate-endpointslice-e2e

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Mar 12, 2026

Part of #7701

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2026
@knative-prow knative-prow bot requested review from dsimansk and skonto March 12, 2026 21:48
@knative-prow
Copy link

knative-prow bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026
@dprotaso dprotaso changed the title switch testing assertions to use endpointslices Switch e2e testing assertions to use EndpointSlices Mar 12, 2026
@dprotaso dprotaso force-pushed the migrate-endpointslice-e2e branch from 129c470 to a0cf276 Compare March 12, 2026 22:06
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.24%. Comparing base (56f2186) to head (8db856b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16454      +/-   ##
==========================================
+ Coverage   80.17%   80.24%   +0.07%     
==========================================
  Files         217      217              
  Lines       13520    13520              
==========================================
+ Hits        10839    10849      +10     
+ Misses       2314     2305       -9     
+ Partials      367      366       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member Author

/retest

if err != nil {
return false, err
}
func waitForEndpointsState(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few var/func names that still use endpoint or endpoints, we could update those to slices?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth it - in the end we are looking at endpoints - whether that comes from corev1.Endpoints vs. discoveryv1.EndpointSlices shouldn't matter for these assertions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants