Switch e2e testing assertions to use EndpointSlices#16454
Switch e2e testing assertions to use EndpointSlices#16454dprotaso wants to merge 4 commits intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
129c470 to
a0cf276
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16454 +/- ##
==========================================
+ Coverage 80.17% 80.24% +0.07%
==========================================
Files 217 217
Lines 13520 13520
==========================================
+ Hits 10839 10849 +10
+ Misses 2314 2305 -9
+ Partials 367 366 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
| if err != nil { | ||
| return false, err | ||
| } | ||
| func waitForEndpointsState( |
There was a problem hiding this comment.
There are a few var/func names that still use endpoint or endpoints, we could update those to slices?
There was a problem hiding this comment.
I don't think it's worth it - in the end we are looking at endpoints - whether that comes from corev1.Endpoints vs. discoveryv1.EndpointSlices shouldn't matter for these assertions
Part of #7701