Skip to content

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Mar 14, 2025

Which issue(s) this PR fixes:

Part of knative/hack#416

What this PR does, why we need it:

This PR just imports the schema tool from knative/hack to ease the PR review for the following PRs.

I plan to fix knative/hack#416, by incorporating changes from knative/hack#417 and including the modscope current code.

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from mgencur and psschwei March 14, 2025 11:21
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/assign @dsimansk
/cc @upodroid
/cc @dprotaso

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/test unit-tests

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

I don't get those weird unit test failures. I couldn't reproduce those on my PC. Looking further...

@cardil cardil force-pushed the chore/schema-gen branch from 023b0e0 to 1e73821 Compare March 14, 2025 12:08
@dprotaso
Copy link
Member

We probably don't need this tool anymore and can use controller tools now - where is it being used?

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

It is used in sample-controller. I forked that controller to do my experiments.

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

Same unit test failing here, as well.

@dprotaso
Copy link
Member

I removed it from sample-controller

knative-extensions/sample-controller#931

I think we should delete this tool and not maintain it

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

Gotta.

/close

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

@cardil: Closed this PR.

Details

In response to this:

Gotta.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot closed this Mar 14, 2025
@cardil cardil deleted the chore/schema-gen branch March 14, 2025 16:14
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

Eventing is using that as well: https://github.com/knative/eventing/blob/main/cmd/schema/main.go

They should migrate off it, as well, as you've shown @dprotaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema tool produce invalid docs in vendorless projects

3 participants