-
Notifications
You must be signed in to change notification settings - Fork 13
Import schema-gen from knative/hack #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit-tests |
|
I don't get those weird unit test failures. I couldn't reproduce those on my PC. Looking further... |
023b0e0 to
1e73821
Compare
|
We probably don't need this tool anymore and can use controller tools now - where is it being used? |
|
It is used in sample-controller. I forked that controller to do my experiments. |
|
|
|
I removed it from sample-controller knative-extensions/sample-controller#931 I think we should delete this tool and not maintain it |
|
Gotta. /close |
|
@cardil: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Eventing is using that as well: https://github.com/knative/eventing/blob/main/cmd/schema/main.go They should migrate off it, as well, as you've shown @dprotaso |
Which issue(s) this PR fixes:
Part of knative/hack#416
What this PR does, why we need it:
This PR just imports the schema tool from knative/hack to ease the PR review for the following PRs.
I plan to fix knative/hack#416, by incorporating changes from knative/hack#417 and including the modscope current code.