test: integration tests for sqlite#195
Merged
MattiasMTS merged 3 commits intokndndrj:masterfrom Mar 12, 2025
Merged
Conversation
MattiasMTS
force-pushed
the
ms/integration-test-sqlite
branch
from
14586e1 to
00fdc3d
Compare
phdah
approved these changes
Mar 11, 2025
Contributor
phdah
left a comment
phdah
left a comment
There was a problem hiding this comment.
Looks awesome! I will take this generic ts to the duckdb test as well. Left some questions and suggestions that would be nice to be evaluated.
MattiasMTS
force-pushed
the
ms/integration-test-sqlite
branch
2 times, most recently
from
a540d14 to
65e9a72
Compare
MattiasMTS
force-pushed
the
ms/integration-test-sqlite
branch
from
65e9a72 to
464e1a0
Compare
MattiasMTS
force-pushed
the
ms/integration-test-sqlite
branch
from
464e1a0 to
771e150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to the driver to mimic how we do it in other places.
The tests in this case might be a bit bloated/unorthodox, given sqlite is lightweight and containers aren't 'truly' needed.
However, in order to easier reproduce dependencies/seed etc it is useful to have an isolated container, where tools related to specific sqlite-driver can be installed (not up to the developer to have e.g. sqlite3 CLI installed). For example, adding the seed in this case is done via the
sqlite3CLI, which the CI/CD or developers might have. But, what they do have is docker/virtualisation installed and that is IMO the only tool a developer should need to run the tests. WDYT?EDIT: I know there is a preinstalled sqlite image (https://hub.docker.com/r/keinos/sqlite3) but I chose simplicity/control by just installing it ourselves instead.