Enh/kds 546 variable and info button #58
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR replaces custom dialog popover implementations with standardized KDS (KNIME Design System) components for flow variable and description buttons, improving consistency and maintainability.
Changes:
- Replaced custom
FlowVariableIconandDialogPopoverwithKdsVariableToggleButtonandKdsInfoToggleButtonfrom@knime/kds-components - Simplified description popover implementation by removing custom styling and using KDS components
- Updated flow variable button to use computed properties for state management instead of tooltip prefix logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FlowVariableButton.vue | Replaces custom icon and popover with KDS toggle buttons, adds state management for variable settings |
| DescriptionPopover.vue | Simplifies component by replacing custom implementation with KDS popover and toggle button |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <KdsInfoToggleButton v-model="open" :visible="hover" /> | ||
| </template> | ||
| </DialogPopover> | ||
| <div v-html="html" /> |
There was a problem hiding this comment.
Using v-html without sanitization can expose the application to XSS attacks. If the html prop contains user-generated content or data from external sources, it should be sanitized before rendering. Consider using a sanitization library or validating that the content source is trusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.