Open
Conversation
3nol
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Updates the Box filehandling plug-in to use the relocated OkHttpProxyAuthenticator and adjusts OSGi bundle requirements to match the newer KNIME/OkHttp baselines referenced by the PR description.
Changes:
- Switch
BoxFileSystemto importOkHttpProxyAuthenticatorfromorg.knime.core.util.auth. - Raise the minimum required
org.knime.corebundle version to5.12.0. - Raise the minimum required
com.squareup.okhttp3.okhttpbundle version to4.12.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
org.knime.ext.box.filehandling/src/org/knime/ext/box/filehandling/fs/BoxFileSystem.java |
Updates authenticator import to the new KNIME location. |
org.knime.ext.box.filehandling/META-INF/MANIFEST.MF |
Updates required bundle version ranges for KNIME Core and OkHttp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
3nol
force-pushed
the
todo/AP-25751-move-proxy-authenticator-to-knime-shared
branch
from
d8e2c4f to
28bb704
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-25751 (Move OkHttpProxyAuthenticator to knime-shared and clean up Kotlin dependencies)