UIEXT-3484: WebUI-Migration Find MIME-Type#42
Open
tcrundall-tng wants to merge 5 commits intomasterfrom
Open
Conversation
tcrundall-tng
requested review from
a team,
Copilot and
knime-ghub-bot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Migrates the Find MIME-Type node to the WebUI parameters/dialog framework and replaces the legacy XML-based node description with a programmatic description, including snapshot-based tests for the new parameter model.
Changes:
- Replaced the legacy Swing dialog with
NodeParameters(WebUI) for column selection, including an auto-guess value provider. - Updated the node factory to provide a WebUI dialog (
DefaultNodeDialog), KAI interface, and programmatic node description; removed the oldNodeFactory.xml. - Added snapshot-based tests and snapshots for the new parameters, plus a small auto-guess fallback in
NodeModel.configure.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.../FindMIMETypeNodeParameters.java |
Introduces WebUI NodeParameters for the node dialog/settings. |
.../FindMIMETypeNodeModel.java |
Adds auto-guessing of the URI column during configure if unset. |
.../FindMIMETypeNodeFactory.xml |
Removes legacy XML node description. |
.../FindMIMETypeNodeFactory.java |
Adds WebUI dialog/description/KAI integration via factory utilities. |
.../FindMIMETypeNodeParametersTest.java |
Adds snapshot test coverage for the new parameters. |
...FindMIMETypeNodeParametersTest*.snap |
Adds expected JSON forms/settings snapshots for the test. |
.../files/node_settings/FindMIMETypeNodeParameters.xml |
Adds legacy settings XML used as snapshot test input. |
Comments suppressed due to low confidence (1)
org.knime.base.filehandling/src/org/knime/base/filehandling/findmimetype/FindMIMETypeNodeParameters.java:82
m_columnSelectionis left uninitialized, so it can benull(and the generated JSON schema won’t have a default). Other migrated NodeParameters in this module initialize string settings to""to avoid nulls and keep defaults consistent with the legacy SettingsModel default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...me.base.filehandling/src/org/knime/base/filehandling/findmimetype/FindMIMETypeNodeModel.java
Show resolved
Hide resolved
.../test_snapshots/org.knime.base.filehandling.findmimetype.FindMIMETypeNodeParametersTest.snap
Outdated
Show resolved
Hide resolved
...test_snapshots/org.knime.base.filehandling.findmimetype.FindMIMETypeNodeParametersTest1.snap
Outdated
Show resolved
Hide resolved
tcrundall-tng
force-pushed
the
enh/UIEXT-3484-webui-migration-find-mime-type
branch
from
e0d4066 to
ead32fb
Compare
…oicesProvider AP-23709 (Support username and password fields instead of flow variables in OAuth2 Authenticator nodes)
tcrundall-tng
force-pushed
the
enh/UIEXT-3484-webui-migration-find-mime-type
branch
from
ead32fb to
1070d4f
Compare
UIEXT-3484 (WebUI-Migration Find MIME-Type)
UIEXT-3484 (WebUI-Migration Find MIME-Type)
UIEXT-3484 (WebUI-Migration Find MIME-Type)
tcrundall-tng
force-pushed
the
enh/UIEXT-3484-webui-migration-find-mime-type
branch
from
1070d4f to
ed9bc04
Compare
UIEXT-3484 (WebUI-Migration Find MIME-Type)
Author
|
|
|
mgohm
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIEXT-3484 (WebUI-Migration Find MIME-Type)