UIEXT-3487 WebUI-Migration Binary Objects to PNGs by tcrundall-tng · Pull Request #44 · knime/knime-filehandling

tcrundall-tng · 2026-03-25T11:20:51Z

No description provided.

…oicesProvider AP-23709 (Support username and password fields instead of flow variables in OAuth2 Authenticator nodes)

Copilot

Pull request overview

This PR migrates the “Binary Objects to PNGs” node to the WebUI parameter framework (including generated node description) and updates Box Authenticator settings to use the newer credentials widget/migration setup.

Changes:

Introduce BinaryObjectsToPNGsNodeParameters and migrate the node factory to WebUI dialogs + programmatic node description (removing the legacy XML description).
Add auto-guessing of the binary-object input column during configure() for “Binary Objects to PNGs”.
Update Box Authenticator app credentials settings to use LegacyCredentials with validation and flow-variable migration; bump plugin/test versions and update snapshots.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAuthenticatorSettings.java	Annotates nested app settings with `@ValueReference` to enable WebUI validation wiring.
org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java	Switches from flow-variable string to `LegacyCredentials` + custom validation/migration.
org.knime.ext.box.authenticator/META-INF/MANIFEST.MF	Bumps bundle version to 5.12.0.qualifier.
org.knime.ext.box.authenticator.tests/pom.xml	Aligns test plugin revision to 5.12.0.
org.knime.ext.box.authenticator.tests/files/test_snapshots/org.knime.ext.box.authenticator.node.BoxAuthenticatorSettingsTest.snap	Updates snapshot to new credential schema/ui format.
org.knime.ext.box.authenticator.tests/META-INF/MANIFEST.MF	Bumps fragment version and host lower bound to 5.12.0.
org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeParameters.java	Adds new WebUI `NodeParameters` model for the node (column, output mode, new column name).
org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeModel.java	Adds column auto-guessing in `configure()` when selection is empty.
org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeFactory.xml	Removes legacy XML node description in favor of programmatic description.
org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeFactory.java	Migrates to `DefaultNodeDialog`/KAI and programmatic node description.
org.knime.base.filehandling.tests/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeParametersTest.java	Replaces legacy dialog test with snapshot tests for WebUI parameters/settings.
org.knime.base.filehandling.tests/files/test_snapshots/org.knime.base.filehandling.binaryobjectstopngs.BinaryObjectsToPNGsNodeParametersTest1.snap	Adds JSON-forms snapshot for a populated settings instance.
org.knime.base.filehandling.tests/files/test_snapshots/org.knime.base.filehandling.binaryobjectstopngs.BinaryObjectsToPNGsNodeParametersTest0.settings.xml.snap	Adds settings-XML structure snapshot for loaded settings.
org.knime.base.filehandling.tests/files/test_snapshots/org.knime.base.filehandling.binaryobjectstopngs.BinaryObjectsToPNGsNodeParametersTest.snap	Adds JSON-forms snapshot for defaults.
org.knime.base.filehandling.tests/files/node_settings/BinaryObjectsToPNGsNodeParameters.xml	Adds a representative node settings fixture used by snapshots.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...xt.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java

...g/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeParameters.java

Copilot · 2026-03-25T11:27:56Z

...g/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeParameters.java

+    private enum OutputMode {
+            @Label(value = "Replace", description = "Replaces the selected binary object column with the PNG column.")
+            Replace, //
+            @Label(value = "Append", description = "Appends a new PNG column to the table.")
+            Append;
+    }
+
+    /**
+     * Persists the OutputMode enum as the legacy string values "Append" / "Replace" under key "replace".
+     */
+    private static final class OutputModePersistor implements NodeParametersPersistor<OutputMode> {
+
+        private static final String CFG_KEY = "replace";
+
+        @Override
+        public OutputMode load(final NodeSettingsRO settings) throws InvalidSettingsException {
+            final String value = settings.getString(CFG_KEY);
+            return OutputMode.valueOf(value);
+        }


OutputMode enum constants are mixed-case (Replace/Append), which is inconsistent with the existing ReplacePolicy enum in the same package (REPLACE/APPEND) and other node-parameter enums in this repository. Consider renaming constants to uppercase and adjusting OutputModePersistor to map the legacy persisted strings ("Replace"/"Append") to the new constants, similar to other legacy persistors (e.g., PNGsToBinaryObjectsNodeSettings.LegacyReplacePersistor).

This is deliberate, such that the enum name matches the persisted string.

We generally reuse existing enums but I can see your point.

You could reuse the old enum and add a "getFromValue" method which you would use in the load method of this persistor similar to here which also would resolve these sonar issues.

But since the old enum is only used in this node I could also live with your solution. I'll let you decide.

It initially felt strange to me to have two enums (which is unavoidable) and use the old enum as a mapping to the persistence key/layer, but after more thought I think that actually makes sense. The old enum is therefore the source of truth for how the keys are defined and serves as a mapping between display and persistence.

I'll do as you suggest (assuming I've understood).

Done. Didn't do an exhaustive scan through all values, instead just compared string value to one and chose the other if not matching.

...ndling/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeModel.java

tcrundall-tng · 2026-03-25T11:47:26Z

⚠️ Should only be merged once #43 is merged ⚠️

mgohm

If #43 is merged and @tcrundall-tng checked my comment its ready to be merged

mgohm · 2026-03-25T12:30:48Z

...g/src/org/knime/base/filehandling/binaryobjectstopngs/BinaryObjectsToPNGsNodeParameters.java

+    private enum OutputMode {
+            @Label(value = "Replace", description = "Replaces the selected binary object column with the PNG column.")
+            Replace, //
+            @Label(value = "Append", description = "Appends a new PNG column to the table.")
+            Append;
+    }
+
+    /**
+     * Persists the OutputMode enum as the legacy string values "Append" / "Replace" under key "replace".
+     */
+    private static final class OutputModePersistor implements NodeParametersPersistor<OutputMode> {
+
+        private static final String CFG_KEY = "replace";
+
+        @Override
+        public OutputMode load(final NodeSettingsRO settings) throws InvalidSettingsException {
+            final String value = settings.getString(CFG_KEY);
+            return OutputMode.valueOf(value);
+        }


We generally reuse existing enums but I can see your point.

You could reuse the old enum and add a "getFromValue" method which you would use in the load method of this persistor similar to here which also would resolve these sonar issues.

But since the old enum is only used in this node I could also live with your solution. I'll let you decide.

UIEXT-3487 (WebUI-Migration Binary Objects to PNGs)

sonarqubecloud · 2026-03-25T14:50:38Z

Quality Gate failed

Failed conditions
83.3% Coverage on New Code (required ≥ 85%)
6.2% Duplication on New Code (required ≤ 1%)

See analysis details on SonarQube Cloud

AP-23709: Fix deprecated box auth settings using CredentialsFlowVarCh…

1fa1f98

…oicesProvider AP-23709 (Support username and password fields instead of flow variables in OAuth2 Authenticator nodes)

tcrundall-tng requested a review from a team as a code owner March 25, 2026 11:20

tcrundall-tng requested review from Copilot and knime-ghub-bot and removed request for a team March 25, 2026 11:20

Copilot started reviewing on behalf of tcrundall-tng March 25, 2026 11:21 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

tcrundall-tng force-pushed the enh/UIEXT-3487-webui-migration-binary-objects-to-pngs branch from 6417edf to bf48300 Compare March 25, 2026 11:40

mgohm reviewed Mar 25, 2026

View reviewed changes

UIEXT-3487: WebUI-Migration Binary Objects to PNGs

cfa9c34

UIEXT-3487 (WebUI-Migration Binary Objects to PNGs)

tcrundall-tng force-pushed the enh/UIEXT-3487-webui-migration-binary-objects-to-pngs branch from bf48300 to cfa9c34 Compare March 25, 2026 14:33

mgohm approved these changes Mar 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UIEXT-3487 WebUI-Migration Binary Objects to PNGs#44

UIEXT-3487 WebUI-Migration Binary Objects to PNGs#44
tcrundall-tng wants to merge 2 commits intomasterfrom
enh/UIEXT-3487-webui-migration-binary-objects-to-pngs

tcrundall-tng commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

tcrundall-tng Mar 25, 2026

Uh oh!

mgohm Mar 25, 2026

Uh oh!

tcrundall-tng Mar 25, 2026

Uh oh!

tcrundall-tng Mar 25, 2026

Uh oh!

Uh oh!

tcrundall-tng commented Mar 25, 2026

Uh oh!

mgohm left a comment

Uh oh!

mgohm Mar 25, 2026

Uh oh!

sonarqubecloud bot commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tcrundall-tng commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

tcrundall-tng Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mgohm Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

tcrundall-tng Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

tcrundall-tng Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tcrundall-tng commented Mar 25, 2026

Uh oh!

mgohm left a comment

Choose a reason for hiding this comment

Uh oh!

mgohm Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 25, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants