UIEXT-3490 WebUI Migration Model to Binary Object#45
Open
tcrundall-tng wants to merge 2 commits intomasterfrom
Open
UIEXT-3490 WebUI Migration Model to Binary Object#45tcrundall-tng wants to merge 2 commits intomasterfrom
tcrundall-tng wants to merge 2 commits intomasterfrom
Conversation
…oicesProvider AP-23709 (Support username and password fields instead of flow variables in OAuth2 Authenticator nodes)
tcrundall-tng
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
Author
|
|
There was a problem hiding this comment.
Pull request overview
Migrates legacy node/dialog settings toward the WebUI/default-dialog infrastructure, including moving the “Model to Binary Object” node to NodeParameters and updating Box Authenticator app credentials handling to a structured credentials object.
Changes:
- Migrated “Model to Binary Object” dialog from legacy
DefaultNodeSettingsPaneto WebUINodeParameters+DefaultNodeDialog, and replaced the XML node description with a programmaticNodeDescription. - Updated Box Authenticator’s app configuration from a credentials flow-variable string to a
LegacyCredentialsobject with migration + validation wiring. - Bumped bundle/test versions and updated snapshot tests to match the new WebUI schemas.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAuthenticatorSettings.java | Adds @ValueReference needed for Box app settings validation. |
| org.knime.ext.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java | Replaces flow-variable string with LegacyCredentials + migration/validation hooks. |
| org.knime.ext.box.authenticator/META-INF/MANIFEST.MF | Version bump to 5.12.0. |
| org.knime.ext.box.authenticator.tests/pom.xml | Test artifact revision bump to 5.12.0. |
| org.knime.ext.box.authenticator.tests/META-INF/MANIFEST.MF | Version bump + Fragment-Host range adjusted. |
| org.knime.ext.box.authenticator.tests/files/test_snapshots/...BoxAuthenticatorSettingsTest.snap | Snapshot updated for new credential object schema and update triggers. |
| org.knime.base.filehandling/src/.../ModelToBinaryObjectNodeParameters.java | Introduces WebUI parameters for the node. |
| org.knime.base.filehandling/src/.../ModelToBinaryObjectNodeFactory.java | Implements WebUI dialog/description/KAI interfaces and constructs a NodeDescription programmatically. |
| org.knime.base.filehandling/src/.../ModelToBinaryObjectNodeFactory.xml | Removes legacy XML node description. |
| org.knime.base.filehandling.tests/src/.../ModelToBinaryObjectNodeParametersTest.java | Adds snapshot test for the new parameters. |
| org.knime.base.filehandling.tests/files/test_snapshots/...ModelToBinaryObjectNodeParametersTest*.snap | New snapshots for JSON forms + settings structure. |
| org.knime.base.filehandling.tests/files/node_settings/ModelToBinaryObjectNodeParameters.xml | Adds test settings fixture for snapshot loading. |
Comments suppressed due to low confidence (1)
org.knime.base.filehandling/src/org/knime/base/filehandling/binaryobjects/model/to/port/ModelToBinaryObjectNodeParameters.java:65
m_columnNamenow defaults to an empty string, but the legacySettingsFactory.createColumnNameSettings()default is "model" andModelToBinaryObjectNodeModel.checkSettings()rejects an empty column name. This changes the out-of-the-box behavior and can make a newly added node invalid until manually edited. Align the default with the legacy settings (e.g., "model") and/or add a required/non-empty validation consistent with the model's constraint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...xt.box.authenticator/src-deprecated/org/knime/ext/box/authenticator/node/BoxAppSettings.java
Show resolved
Hide resolved
tcrundall-tng
force-pushed
the
enh/UIEXT-3490-webui-migration-model-to-binary-object
branch
from
c99fbbc to
d5102a2
Compare
|
reissinj
requested changes
Mar 25, 2026
| import org.knime.node.impl.description.PortDescription; | ||
| import java.util.List; | ||
| import static org.knime.node.impl.description.PortDescription.fixedPort; | ||
|
|
Contributor
There was a problem hiding this comment.
Small thing: put the imports in the right order
UIEXT-3490 (WebUI-Migration Model to Binary Object)
tcrundall-tng
force-pushed
the
enh/UIEXT-3490-webui-migration-model-to-binary-object
branch
from
d5102a2 to
08f5a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.