Fix DI container override callable and private API access in config validation tests

[Copilot]

The setup_test_container fixture was using Mock() for test_settings, causing the DI container to invoke it as a factory (container calls any non-type callable override), returning a different Mock instance instead of the intended settings object. The fixture was also manually snapshotting/restoring container._overrides (private attribute) instead of using the public context manager API.

Changes

• test_settings → NonCallableMock: Prevents Container._resolve_override from treating the settings object as a factory callable. The container returns the mock directly rather than calling it.

• setup_test_container → use_overrides context manager: Replaces manual _overrides dict snapshot/restore with container.use_overrides({CodeWeaverSettingsType: test_settings}), which handles atomic save/restore in its finally block.

# Before: manual private-state manipulation
initial_overrides = dict(container._overrides) if hasattr(container, "_overrides") else {}
container.override(CodeWeaverSettingsType, test_settings)  # test_settings is callable → called as factory
yield container
container.clear_overrides()
for interface, instance in initial_overrides.items():
    container.override(interface, instance)

# After: public API, non-callable mock
with container.use_overrides({CodeWeaverSettingsType: test_settings}):  # NonCallableMock → returned directly
    yield container

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR fixes two bugs in the setup_test_container and test_settings fixtures in the config validation integration tests. The Mock() object used for settings was being invoked as a factory by the DI container (which calls any non-type callable override), and the fixture was manually manipulating private container state for override save/restore.

Changes:

• Changed test_settings from Mock() to NonCallableMock() to prevent the DI container from treating the settings mock as a factory callable.
• Replaced manual _overrides dict snapshot/restore with the public container.use_overrides() context manager, consistent with other integration test files.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

👋 Hey @Copilot,

Thanks for your contribution to codeweaver! 🧵

You need to agree to the CLA first... 🖊️

Before we can accept your contribution, you need to agree to our Contributor License Agreement (CLA).

To agree to the CLA, please comment:

I read the contributors license agreement and I agree to it.

Those exact words are important¹, so please don't change them. 😉

You can read the full CLA here: Contributor License Agreement

---

✅ @Copilot has signed the CLA.

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

Footnotes

1. Our bot needs those exact words to recognize that you agree to the CLA. ↩