Skip to content

Conversation

@bashandbone
Copy link
Contributor

@bashandbone bashandbone commented Oct 29, 2025

Summary by Sourcery

Regenerate coverage report, bump version, and standardize pytest configuration and markers across the test suite

Enhancements:

  • Annotate tests with pytest markers for unit, integration, performance, slow, external_api, validation, and async_test to categorize tests

Build:

  • Add --import-mode=importlib to pytest addopts in pyproject.toml

Tests:

  • Add pytestmark declarations to numerous test modules and adjust formatting to enforce consistent test categorization

Chores:

  • Bump version to 0.0.1rc3+g76d9888
  • Update coverage.xml with regenerated coverage statistics

Copilot AI and others added 15 commits October 27, 2025 14:39
- Added --import-mode=importlib to pytest config to fix namespace collision
- Applied pytestmark to all test files consistently
- Fixed test_selector.py and test_semantic_basic.py missing pytest import
- All 182 tests now collect successfully with proper marks

Co-authored-by: bashandbone <[email protected]>
- Moved pytestmark in test_delimiters.py to after all imports
- Reduced excessive blank lines after pytestmark to single blank line
- All tests still collect and run correctly

Co-authored-by: bashandbone <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Adam Poulemanos <[email protected]>
Fix test collection namespace collision and apply consistent pytest marks
Copilot AI review requested due to automatic review settings October 29, 2025 21:28
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 29, 2025

Reviewer's Guide

This PR pulls in auto-generated coverage updates, standardizes test metadata by adding pytest markers across test suites, bumps the package version, and tweaks pytest configuration to use importlib import mode.

Class diagram for updated test suite metadata and configuration

classDiagram
class pytest_configuration {
  +addopts: list
  +testpaths: list
  +python_files: list
  +import_mode: importlib
}
class Test_Suite {
  +pytest_markers
}
pytest_configuration --> Test_Suite : configures
Loading

File-Level Changes

Change Details Files
Regenerate coverage report with updated metrics
  • Updated timestamp, lines-valid, lines-covered, and line-rates throughout the XML
  • Refreshed coverage statistics for each package and class to reflect latest test runs
coverage.xml
Standardize pytest markers in test modules
  • Inserted pytestmark declarations to categorize tests (unit, integration, benchmark, performance, external_api, async_test)
  • Added missing import pytest statements where new markers were introduced
  • Cleaned up surrounding whitespace for consistency
tests/integration/chunker/test_e2e.py
tests/performance/test_vector_store_performance.py
tests/contract/test_qdrant_provider.py
tests/integration/test_custom_config.py
tests/integration/test_hybrid_ranking.py
tests/integration/test_hybrid_storage.py
tests/integration/test_incremental_updates.py
tests/integration/test_memory_persistence.py
tests/integration/test_partial_embeddings.py
tests/integration/test_persistence.py
tests/unit/engine/chunker/test_delimiter_edge_cases.py
tests/unit/engine/chunker/test_selector.py
tests/unit/engine/chunker/test_semantic_basic.py
tests/unit/engine/chunker/test_semantic_dedup.py
tests/benchmark/chunker/test_performance.py
tests/unit/engine/chunker/test_delimiter_basic.py
tests/unit/engine/chunker/test_semantic_errors.py
tests/contract/test_memory_provider.py
tests/integration/test_provider_switch.py
tests/test_delimiters.py
tests/test_lazy_importer.py
tests/unit/engine/chunker/test_governance.py
tests/unit/engine/chunker/test_semantic_edge_cases.py
tests/unit/engine/chunker/test_semantic_oversized.py
tests/contract/test_vector_store_provider.py
Bump package version
  • Updated version constant to reflect new release candidate identifier
src/codeweaver/_version.py
Enable importlib mode in pytest configuration
  • Added --import-mode=importlib to pytest addopts
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes test markers and pytest configuration across the test suite to improve test organization and selective test execution.

  • Adds pytestmark declarations with appropriate test markers to test files
  • Configures pytest to use --import-mode=importlib for better module isolation
  • Removes extraneous blank lines for consistency

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pyproject.toml Adds --import-mode=importlib to pytest configuration
tests/unit/engine/chunker/test_*.py Adds pytestmark = [pytest.mark.unit] to unit test files
tests/test_*.py Adds pytestmark = [pytest.mark.unit] to root-level unit test files
tests/performance/test_vector_store_performance.py Adds pytestmark with multiple markers (async_test, performance, slow)
tests/integration/test_*.py Removes extra blank lines after existing pytestmark declarations
tests/contract/test_*.py Adds or updates pytestmark with appropriate markers
tests/benchmark/chunker/test_performance.py Adds pytestmark with benchmark, performance, and slow markers
src/codeweaver/_version.py Updates version string (automated)
coverage.xml Updates coverage statistics (automated)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor Author

@bashandbone bashandbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superficial conflicts

@bashandbone bashandbone merged commit 7adbf55 into 003-our-aim-to Oct 30, 2025
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants