-
Notifications
You must be signed in to change notification settings - Fork 1
Pull in updates so we’re working on the same page #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: bashandbone <[email protected]>
- Added --import-mode=importlib to pytest config to fix namespace collision - Applied pytestmark to all test files consistently - Fixed test_selector.py and test_semantic_basic.py missing pytest import - All 182 tests now collect successfully with proper marks Co-authored-by: bashandbone <[email protected]>
- Moved pytestmark in test_delimiters.py to after all imports - Reduced excessive blank lines after pytestmark to single blank line - All tests still collect and run correctly Co-authored-by: bashandbone <[email protected]>
…arks Co-authored-by: bashandbone <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Adam Poulemanos <[email protected]>
Fix test collection namespace collision and apply consistent pytest marks
Reviewer's GuideThis PR pulls in auto-generated coverage updates, standardizes test metadata by adding pytest markers across test suites, bumps the package version, and tweaks pytest configuration to use importlib import mode. Class diagram for updated test suite metadata and configurationclassDiagram
class pytest_configuration {
+addopts: list
+testpaths: list
+python_files: list
+import_mode: importlib
}
class Test_Suite {
+pytest_markers
}
pytest_configuration --> Test_Suite : configures
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes test markers and pytest configuration across the test suite to improve test organization and selective test execution.
- Adds
pytestmarkdeclarations with appropriate test markers to test files - Configures pytest to use
--import-mode=importlibfor better module isolation - Removes extraneous blank lines for consistency
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Adds --import-mode=importlib to pytest configuration |
tests/unit/engine/chunker/test_*.py |
Adds pytestmark = [pytest.mark.unit] to unit test files |
tests/test_*.py |
Adds pytestmark = [pytest.mark.unit] to root-level unit test files |
tests/performance/test_vector_store_performance.py |
Adds pytestmark with multiple markers (async_test, performance, slow) |
tests/integration/test_*.py |
Removes extra blank lines after existing pytestmark declarations |
tests/contract/test_*.py |
Adds or updates pytestmark with appropriate markers |
tests/benchmark/chunker/test_performance.py |
Adds pytestmark with benchmark, performance, and slow markers |
src/codeweaver/_version.py |
Updates version string (automated) |
coverage.xml |
Updates coverage statistics (automated) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bashandbone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superficial conflicts
Summary by Sourcery
Regenerate coverage report, bump version, and standardize pytest configuration and markers across the test suite
Enhancements:
Build:
Tests:
Chores: