Skip to content

Conversation

@bashandbone
Copy link
Contributor

final commit for this branch

Copilot AI review requested due to automatic review settings July 20, 2025 21:09
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2025

⚠️ No Changeset found

Latest commit: 9586984

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashandbone bashandbone merged commit a5a667c into staging Jul 20, 2025
5 of 10 checks passed
@bashandbone bashandbone deleted the feat-integrate-ast-grep branch July 20, 2025 21:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements minor fixes to language configuration, focusing on consolidating bash extension patterns and correcting feature flag mappings. The changes aim to reduce code duplication and fix configuration inconsistencies.

  • Consolidates bash file extension patterns into a reusable constant
  • Fixes incorrect feature flag mapping for TypeScript/TSX
  • Corrects C++ feature flag in extension matching

Comment on lines +110 to +111
const BASH_EXTENSION_PATTERN: [&str; 19] = [
"bash", "bats", "sh", ".bashrc", "bash_aliases", "bats", "cgi", "command", "env",
Copy link

Copilot AI Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension "bats" is duplicated in the array. Remove one of the duplicate entries.

Suggested change
const BASH_EXTENSION_PATTERN: [&str; 19] = [
"bash", "bats", "sh", ".bashrc", "bash_aliases", "bats", "cgi", "command", "env",
const BASH_EXTENSION_PATTERN: [&str; 18] = [
"bash", "bats", "sh", ".bashrc", "bash_aliases", "cgi", "command", "env",

Copilot uses AI. Check for mistakes.
Bash => &[
"bash", "bats", "cgi", "command", "env", "fcgi", "ksh", "sh", "tmux", "tool", "zsh",
],
Bash => &BASH_EXTENSION_PATTERN,
Copy link

Copilot AI Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BASH_EXTENSION_PATTERN constant includes extensions like ".bashrc", "bash_aliases", "bash_logout" which are filenames, not file extensions. These won't match properly in the extensions() function which expects actual file extensions.

Suggested change
Bash => &BASH_EXTENSION_PATTERN,
Bash => &["sh", "bash"],

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants