fix(ast-engine): harden Language::from_path default — better diagnostics and contract tests#102
Merged
bashandbone merged 3 commits intofix-language-from-path-12198073203083672702from Mar 9, 2026
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…add tests Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix panic if from_path is not implemented in ast-engine
fix(ast-engine): harden Language::from_path default — better diagnostics and contract tests
Mar 9, 2026
…ot/sub-pr-98 Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
Contributor
|
👋 Hey @Copilot, Thanks for your contribution to thread! 🧵You need to agree to the CLA first... 🖊️Before we can accept your contribution, you need to agree to our Contributor License Agreement (CLA). To agree to the CLA, please comment:
Those exact words are important1, so please don't change them. 😉 You can read the full CLA here: Contributor License Agreement ✅ @Copilot has signed the CLA. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. Footnotes
|
7bff512
into
fix-language-from-path-12198073203083672702
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
unimplemented!("from_path is not implemented")message gave no indication of which type failed or how to fix it. The doc comment still described the oldNone-returning behavior.Changes
std::any::type_name::<Self>()Some(Self)/Nonedefault_from_path_panics— asserts#[should_panic(expected = "Language::from_path is not implemented for type")]on a bare imploverridden_from_path_does_not_panic— verifies an overriding impl returnsSome/Nonecorrectlytsx_kind_to_id,tsx_field_to_id,tsx_ts_language) to remove duplication across testLanguageimpls🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.