Conversation
Move react-native-gesture-handler from dependencies to peerDependencies in @knocklabs/react-native and @knocklabs/expo so consumer apps do not install duplicate native module copies.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2a22812 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kylemcd
requested review from
MikeCarbone and
thomaswhyyou
and removed request for
a team
thomaswhyyou
approved these changes
Apr 2, 2026
kylemcd
deleted the
kyle-kno-12406-move-react-native-gesture-handler-to-peer-dependencies-in
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 209 209
Lines 9949 9949
Branches 1274 1274
=======================================
Hits 6359 6359
Misses 3565 3565
Partials 25 25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
react-native-gesture-handleris listed as a directdependencyin@knocklabs/react-nativeand@knocklabs/expo, but neither package imports it anywhere in source codedependenciesforce-installs a copy for consumers, who almost always already have it viaexpo-routeror@react-navigation, causing Expo Doctor to flag duplicate native modulespeerDependencies(with>=2.0.0to give consumers flexibility) anddevDependencies(for local development)