Skip to content

test) add a firefox runner #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phillipc merged 1 commit into from
Dec 28, 2025
Merged

test) add a firefox runner #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/test-headless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:

strategy:
matrix:
node-version: [22.x]
jquery: ['off','on']
node-version: [24]
run: ['test-headless','test-headless-jquery', 'test-headless-ff']

steps:
- name: Checkout code
Expand All @@ -32,10 +32,5 @@ jobs:
- name: Run Build
run: make

- name: Run Test-Headless (without JQuery)
if: "contains(${{ matrix.jquery }}, 'off')"
run: make test-headless

- name: Run Test-Headless (with JQuery)
if: "contains(${{matrix.jquery }}, 'on')"
run: make test-headless-jquery
- name: Run ${{ matrix.run }}
run: make ${{ matrix.run }}
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ test-headless:
test-headless-jquery:
$(LERNA) exec --stream -- $(MAKE) test-headless-jquery

test-headless-ff:
$(LERNA) exec --stream -- $(MAKE) test-headless-ff

ci:
$(LERNA) exec --stream --concurrency=1 -- $(MAKE) test-ci

Expand Down
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo apt -y install ./google-chrome-stable_current_amd64.deb
```

Install Firefox for "make test-headless-ff":
```bash
sudo add-apt-repository ppa:mozillateam/ppa
sudo apt install xvfb firefox-esr
sudo ln -s /usr/lib/firefox-esr/firefox.sh /usr/bin/firefox

or
export FIREFOX_BIN=/usr/bin/firefox-esr
```

## Next steps

There's an [issue for that](https://github.com/knockout/tko/issues/1).
Expand Down
Loading