-
Notifications
You must be signed in to change notification settings - Fork 35
Add knip linter and fix all unused dependencies and exports #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phillipc
wants to merge
14
commits into
knockout:main
Choose a base branch
from
Auge19:add_knip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
674898c
knip) adding
phillipc 2d56e2a
ts) enable verbatimModuleSyntax + fix knip finding (import/export)
phillipc b26ac74
knip) fixing some cyclic type imports - introduce IKnockoutInstance a…
phillipc 558f82e
refactor) update dependencies across packages / fix all knip warnings
phillipc 336c221
knip) cleanup
phillipc ab1af6c
workflow) update titel
phillipc 602ac34
knip) disable config hints
phillipc 9c6f5b5
Merge branch 'knockout:main' into add_knip
phillipc a9b86e9
knip) Implementation of the review feedback
phillipc 6da7b30
ts) remove IBindingHandlerObject
phillipc 75ffdf6
format) execute prettier
phillipc cecd4ee
renaming) IProvider to ProviderBase
phillipc ca2704e
bump) knip / fix config
phillipc 658e4f2
fix) update project glob pattern in knip.json and remove unused dupli…
phillipc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Checking package dependencies with knip and lerna | ||
|
|
||
| on: | ||
| # Runs for every pull-requests created | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
| # Allows you to run this workflow manually from the Actions tab | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| knip: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 24 | ||
| cache: 'npm' | ||
|
|
||
| - name: Build TKO | ||
| run: make | ||
|
|
||
| - name: Check for dependency cycles and faulty imports/exports with knip | ||
| run: make knip | ||
|
|
||
| - name: Check lerna packages | ||
| run: make lerna-check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/knip@5/schema.json", | ||
| "ignoreExportsUsedInFile": { | ||
| "interface": true, | ||
| "type": true | ||
| }, | ||
| "tags": [ | ||
| "-lintignore", | ||
| "-internal" | ||
| ], | ||
| "ignoreBinaries": ["make"], | ||
| "ignoreDependencies": ["@types/mocha", "chai", "electron", "esbuild", "fs-extra", "karma[.]*", "mocha", "nyc", "prettier", "sinon", "lerna"], | ||
| "workspaces": { | ||
| "packages/*": { | ||
| "entry": "src/index.ts", | ||
| "project": "src/**/*.ts", | ||
| "ignore": ["/helpers/**"] | ||
| } | ||
| }, | ||
| "ignoreWorkspaces": ["builds/**", "docs/**", "tko.io/**", "tools/**"] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.