Skip to content

update mocha branch#287

Open
phillipc wants to merge 7 commits intobmh/sc-mocha-test-modernizationfrom
pc/update_mocha_branch
Open

update mocha branch#287
phillipc wants to merge 7 commits intobmh/sc-mocha-test-modernizationfrom
pc/update_mocha_branch

Conversation

@phillipc
Copy link
Copy Markdown
Member

@phillipc phillipc commented Apr 6, 2026

Merge main to bmh/sc-mocha-test-modernization and adds some small fixes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4bc9c4e8-8952-4579-9a63-72de3bfc18ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pc/update_mocha_branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phillipc phillipc marked this pull request as draft April 6, 2026 12:09
@phillipc
Copy link
Copy Markdown
Member Author

phillipc commented Apr 6, 2026

Current status: The last challenge are the knockout build tests and the clean loading process of Chai as an ESM.

@phillipc phillipc changed the title Pc/update mocha branch update mocha branch Apr 6, 2026
@phillipc phillipc marked this pull request as ready for review April 6, 2026 19:37
@phillipc phillipc requested a review from brianmhunt April 6, 2026 19:37
@phillipc
Copy link
Copy Markdown
Member Author

phillipc commented Apr 6, 2026

Hey @brianmhunt, I have reintegrated the main branch into your Mocha porting branch and made some fixes. Feel free to merge it.

Key changes:

  • Merge integration: integrated the latest main branch code into the test modernisation branch to ensure all ongoing changes are captured.

  • Dependency cleanup: removed chai and sinon from package.json files across the monorepo.

  • Build compatibility: fixed Knockout-Build-Tests to resolve issues with clean ESM module loading for Chai and ensure proper test execution in the build suite.

  • Type safety: added a Mocha type reference to global.d.ts to enable proper TypeScript support for test globals across the codebase.

  • Code quality: Make it ESLint compliant.

  • Formatting: applied Prettier formatting to the modified files for consistency.

@phillipc
Copy link
Copy Markdown
Member Author

phillipc commented Apr 6, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant