feat: add includeTag parameter to doBuild for tagged references #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where "resourceKoBuildCreate" uses the result of "doPublish" as the "image_ref", but in "resourceKoBuildRead" the result of "doBuild" as the "image_ref". This causes an issue when a single "tags" is configured and the "image_ref" from "doPublish" will include the tag, but the the "image_ref" from "doBuild" does not, and will always cause the resource to be recreated. - Add includeTag boolean parameter to doBuild function - When includeTag is true, return tagged reference with digest appended - Update doBuild calls: false for Create, true for Read operations - Maintains backward compatibility with existing behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where "resourceKoBuildCreate" uses the result of "doPublish" as the "image_ref", but in "resourceKoBuildRead" the result of "doBuild" as the "image_ref". This causes an issue when a single "tags" is configured and the "image_ref" from "doPublish" will include the tag, but the the "image_ref" from "doBuild" does not, and will always cause the resource to be recreated.
This PR: