Skip to content

Fix: multiple files upload #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: multiple files upload #122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c96d1b
Fix: multiple files upload
billchenchina May 30, 2018
070a979
Fix: use Array.isArray and not special-case
billchenchina May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions upload/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,21 @@ app.use(async function(ctx, next) {
// ignore non-POSTs
if ('POST' != ctx.method) return await next();

const file = ctx.request.body.files.file;
const reader = fs.createReadStream(file.path);
const stream = fs.createWriteStream(path.join(os.tmpdir(), Math.random().toString()));
reader.pipe(stream);
console.log('uploading %s -> %s', file.name, stream.path);
const files = ctx.request.body.files.file;
if (files instanceof Array) {
Copy link

@fl0w fl0w May 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with Array.isArray here, even better would be to not special-case and DRY streaming (e.g. always assume arrays).

files.forEach(function(file, index) {
const reader = fs.createReadStream(file.path);
const stream = fs.createWriteStream(path.join(os.tmpdir(), Math.random().toString()));
reader.pipe(stream);
console.log('uploading %s -> %s', file.name, stream.path);
});
} else {
const file = files;
const reader = fs.createReadStream(file.path);
const stream = fs.createWriteStream(path.join(os.tmpdir(), Math.random().toString()));
reader.pipe(stream);
console.log('uploading %s -> %s', file.name, stream.path);
}

ctx.redirect('/');
});
Expand Down