add support for mgcv ocat models #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should add support for the ordered categorical models available in
mgcvfor a while now via theocatfamily. Mathematical details are in https://www.maths.ed.ac.uk/~swood34/gsm.pdf, but are not that different from the other models supported bysure.I knocked this together fairly quickly and I think it works (comparison between the equivalent
polrmodel for yourdf1seems about right, as do plots for some data I'm working on) but I may have missed some critical internal thing, not being fully immersed in the package details.Hope this is useful and thanks for the package, it's very handy.