refactor(analysis): migrate select one form to mantine DEV-1169 #6462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duvld
changed the title
duvld
changed the title
Akuukis
requested changes
Nov 12, 2025
Comment on lines
75
to
84
| <Stack gap={'xs'}> | ||
| {getOptions().map((option) => ( | ||
| <Radio | ||
| value={option.value} | ||
| label={option.label} | ||
| onChange={(newResponse) => onRadioChange(newResponse.currentTarget.value)} | ||
| checked={response === option.value} | ||
| /> | ||
| ))} | ||
| </Stack> |
Contributor
magicznyleszek
requested changes
Nov 12, 2025
Member
magicznyleszek
left a comment
magicznyleszek
left a comment
There was a problem hiding this comment.
Generaly works fine (tested), but I have some more general questions :)
| /> | ||
| <Stack gap={'xs'}> | ||
| {getOptions().map((option) => ( | ||
| <Radio |
Member
There was a problem hiding this comment.
I noticed that Radio doesn't have pointer cursor
jsapp/js/components/processing/analysis/responseForms/selectOneResponseForm.component.tsx
Show resolved
Hide resolved
duvld
force-pushed
the
anji/dev-1169-select-one-to-mantine
branch
from
a0969cd to
d76a4ea
Compare
duvld
force-pushed
the
anji/dev-1169-select-one-to-mantine
branch
from
d76a4ea to
d1bde78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
#Support Docs Updates, if any<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow💭 Notes
The "best" solution would probably be to refactor all of
radio.tsxto mantine, but that creates a bigger problem than this scope. Ourradio.tsx(not using mantine) has the ability to de-select options, if we convert it to use mantineRadio, then there will be a regression to this feature. To offset this for the qualitative analysis project we introduced a clear button--this has not been done everywhere aradio.tsxis being used. Further investigation into this is needed, but out of scope of this PR👀 Preview steps