Skip to content

use hypot to calculate length #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nader-eloshaiker wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use hypot to calculate length #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef44673
use hypot to calculate length
nader-eloshaiker Dec 20, 2017
3a3802d
fixed comma separator
nader-eloshaiker Dec 20, 2017
b238559
replace deplicated M_PI with Double.pi
nader-eloshaiker Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SKTUtils/CGFloat+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import CoreGraphics

/** The value of π as a CGFloat */
let π = CGFloat(M_PI)
let π = CGFloat(Double.pi)

public extension CGFloat {
/**
Expand Down
2 changes: 1 addition & 1 deletion SKTUtils/CGPoint+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public extension CGPoint {
* Returns the length (magnitude) of the vector described by the CGPoint.
*/
public func length() -> CGFloat {
return sqrt(x*x + y*y)
return hypot(x, y)
}

/**
Expand Down
2 changes: 1 addition & 1 deletion SKTUtils/CGVector+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public extension CGVector {
* Returns the length (magnitude) of the vector described by the CGVector.
*/
public func length() -> CGFloat {
return sqrt(dx*dx + dy*dy)
return hypot(dx, dy)
}

/**
Expand Down