Skip to content

feat: improve yaml template sync audit log detail #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lilianzhu merged 2 commits into from
May 7, 2026
Merged

feat: improve yaml template sync audit log detail #4664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dca3f9
feat: improve yaml template sync audit log detail
huanghongbo-hhb Apr 30, 2026
6c4323b
refactor: format yaml template sync audit log detail
huanghongbo-hhb Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion pkg/microservice/aslan/core/templatestore/handler/yaml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (

"github.com/gin-gonic/gin"
"github.com/koderover/zadig/v2/pkg/types"
"go.uber.org/zap"

commonmodels "github.com/koderover/zadig/v2/pkg/microservice/aslan/core/common/repository/models"
"github.com/koderover/zadig/v2/pkg/microservice/aslan/core/common/service/template"
Expand Down Expand Up @@ -467,7 +468,8 @@ func SyncYamlTemplateReference(c *gin.Context) {
return
}

internalhandler.InsertOperationLog(c, ctx.UserName, "", "同步", "模板-YAML", c.Param("id"), c.Param("id"), "", types.RequestBodyTypeJSON, ctx.Logger)
detail, detailEn := buildYamlTemplateSyncLogDetail(c.Param("id"), ctx.Logger)
internalhandler.InsertOperationLog(c, ctx.UserName, "", "同步", "模板-YAML", detail, detailEn, "", types.RequestBodyTypeJSON, ctx.Logger)

// authorization check
if !ctx.Resources.IsSystemAdmin {
Expand All @@ -480,6 +482,43 @@ func SyncYamlTemplateReference(c *gin.Context) {
ctx.RespErr = templateservice.SyncYamlTemplateReference(ctx.UserName, c.Param("id"), ctx.Logger)
}

func buildYamlTemplateSyncLogDetail(templateID string, logger *zap.SugaredLogger) (string, string) {
templateDetail, err := templateservice.GetYamlTemplateDetail(templateID, logger)
if err != nil {
logger.Warnf("failed to get yaml template detail for operation log, templateID: %s, err: %v", templateID, err)
return templateID, templateID
}

references, err := templateservice.GetYamlTemplateReference(templateID, logger)
if err != nil {
logger.Warnf("failed to get yaml template references for operation log, templateID: %s, err: %v", templateID, err)
return fmt.Sprintf("模板名称:%s", templateDetail.Name), fmt.Sprintf("Template Name: %s", templateDetail.Name)
}

serviceRefs := make([]string, 0, len(references))
serviceRefsEn := make([]string, 0, len(references))
for _, reference := range references {
if reference == nil {
continue
}
envTypeCN := "测试"
envTypeEN := "test"
if reference.Production {
envTypeCN = "生产"
envTypeEN = "production"
}
serviceRefs = append(serviceRefs, fmt.Sprintf("%s/%s(%s)", reference.ProjectName, reference.ServiceName, envTypeCN))
serviceRefsEn = append(serviceRefsEn, fmt.Sprintf("%s/%s(%s)", reference.ProjectName, reference.ServiceName, envTypeEN))
}

if len(serviceRefs) == 0 {
return fmt.Sprintf("模板名称:%s", templateDetail.Name), fmt.Sprintf("Template Name: %s", templateDetail.Name)
}

return fmt.Sprintf("模板名称:%s\n影响服务:\n%s", templateDetail.Name, strings.Join(serviceRefs, "\n")),
fmt.Sprintf("Template Name: %s\nAffected Services:\n%s", templateDetail.Name, strings.Join(serviceRefsEn, "\n"))
}

type getYamlTemplateVariablesReq struct {
Content string `json:"content" binding:"required"`
VariableYaml string `json:"variable_yaml" binding:"required"`
Expand Down
Loading