Patch zlib build for cmake 4 #978
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the minimum version to 3.5 as required by cmake 4. Only tested generate and build
|
Why not just bump zlib to 1.3 or 1.3.1? |
Contributor
Author
Primarily because of full testing which is out of scope for me. If @phunkyfish prefers I could submit depends/common/zilib from Piers. |
Member
|
That might be easier |
Contributor
Author
If you mean bring in Piers zlib it isn't easier but I can do that if you want. |
Member
|
I meant from a maintenance perspective, at least then you know it's tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the minimum version to 3.5 as required by cmake 4. Only tested generate and build