Handle icc profiles and images with transparency#2210
Open
Hirmuolio wants to merge 6 commits intokohya-ss:mainfrom
Open
Handle icc profiles and images with transparency#2210Hirmuolio wants to merge 6 commits intokohya-ss:mainfrom
Hirmuolio wants to merge 6 commits intokohya-ss:mainfrom
Conversation
kohya-ss
reviewed
Sep 28, 2025
Owner
kohya-ss
left a comment
kohya-ss
left a comment
There was a problem hiding this comment.
I'm not familiar with color profiles, but this pull request looks good overall. Please check out the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert images with icc profile into sRGB.
If the conversion fails due to image using color profile that pillow doesn't know an error is raised.
Raises error if image is an animation.
The script currently ignores GIFs. Those could be added in now. PNG and JXL can also contain animations.
When training without alpha adds white background to transparent images.
Just calling
image = image.convert("RGB")on image with transparency will often result in ugly background.Instead of raising errors the problem images could be silently ignored. But I think telling the user something is wrong is better.
Closes #2179