Draft
Conversation
timbertson
commented
Sep 21, 2025
std/async/process.kk
Outdated
| finalize-process(process, kill-strategy) | ||
|
|
||
| // close the half of any pipes that are only used by the child | ||
| close-owned(uv-stdout) |
Contributor
Author
There was a problem hiding this comment.
This is the function that never returns (when there's a stream to close)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything compiles, but there's two issues before this can work:
uv/stream/read-startinterface seems too limited - it doesn't handle the error or EOF case, which means I can't consume a pipe until it endsclose-owned- the async callback passed touv_closenever seems to be triggered, not sure if that's specific to pipes or not 😕