Simplify the creation of Docker/Singularity images#237
Merged
yasahi-hpc merged 4 commits intomainfrom Mar 24, 2025
Merged
Conversation
3bceff3 to
bc6fcbd
Compare
94ef471 to
6eeff64
Compare
yasahi-hpc
reviewed
Mar 24, 2025
yasahi-hpc
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the recent security breach that affected the
tj-actions/changed-filesGitHub action, this was a good opportunity to reevaluate the way the project manages the creation of Docker images.Currently, we have 2 sets of images: one for when the Dockerfiles are not modified (prefixed
_main), and one for when the Dockerfiles are modified (prefixed_pr). Any feature branch that updated the Dockerfiles would then re-create its images on the fly. While very flexible, this process has not proven to be intensively used. Updating the Docker images is a somehow rare task. On the other hand, it generated a lot of complexity in the CI files.This PR proposes to simplify the creation of Docker/Singularity images by separating the workflow between
create_images, that only takes care of creating the images when a Dockerfile is modified, and the traditionalbuild_test, that only uses the images. The registry will then only have one set of images, without suffixes.If images need to be modified, then this should be done in a 2-step approach:
Progress so far: