Skip to content

[HIPFFT] Special assertion handler for HIPFFT backend#409

Merged
yasahi-hpc merged 2 commits intokokkos:mainfrom
yasahi-hpc:improve-hipfft-assert
Feb 16, 2026
Merged

[HIPFFT] Special assertion handler for HIPFFT backend#409
yasahi-hpc merged 2 commits intokokkos:mainfrom
yasahi-hpc:improve-hipfft-assert

Conversation

@yasahi-hpc
Copy link
Collaborator

This PR aims at improving the error messages when HIPFFT fails.
See also #407 for cuFFT.

@yasahi-hpc yasahi-hpc self-assigned this Feb 9, 2026
Copy link
Member

@tretre91 tretre91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yasahi-hpc
Copy link
Collaborator Author

Thanks for your review @tretre91
I will probably factorize a bit more like #410
I also need to test this as soon as adastra is back

@yasahi-hpc yasahi-hpc force-pushed the improve-hipfft-assert branch from 7f9d136 to 27065ba Compare February 16, 2026 11:04
@yasahi-hpc
Copy link
Collaborator Author

Thank you for approval @tretre91
I will merge this

@yasahi-hpc yasahi-hpc merged commit 20127da into kokkos:main Feb 16, 2026
41 of 42 checks passed
@yasahi-hpc yasahi-hpc deleted the improve-hipfft-assert branch February 16, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants