Skip to content

Mark NewtonSolve as nodiscard #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwpearson wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Mark NewtonSolve as nodiscard #2551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999fe5c
Mark NewtonSolve as nodiscard
cwpearson Mar 17, 2025
297c9fc
KOKKOS_ATTRIBUTE_NODISCARD -> [[nodiscard]]
cwpearson Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ode/impl/KokkosODE_Newton_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace Impl {

template <class system_type, class mat_type, class ini_vec_type, class rhs_vec_type, class update_type,
class scale_type>
KOKKOS_FUNCTION KokkosODE::Experimental::newton_solver_status NewtonSolve(
[[nodiscard]] KOKKOS_FUNCTION KokkosODE::Experimental::newton_solver_status NewtonSolve(
system_type& sys, const KokkosODE::Experimental::Newton_params& params, mat_type& J, mat_type& tmp,
ini_vec_type& y0, rhs_vec_type& rhs, update_type& update, const scale_type& scale) {
using newton_solver_status = KokkosODE::Experimental::newton_solver_status;
Expand Down
Loading