Skip to content

#66 - feat: allow to skip all deps#124

Open
CaporalDead wants to merge 1 commit intokoliveira15:mainfrom
CaporalDead:feat/skip-all-deps
Open

#66 - feat: allow to skip all deps#124
CaporalDead wants to merge 1 commit intokoliveira15:mainfrom
CaporalDead:feat/skip-all-deps

Conversation

@CaporalDead
Copy link

@CaporalDead CaporalDead commented Nov 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Configuration related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • @koliveira15/nx-sonarqube
  • docs-site

What is the current behavior?

For now, we can only ignore implicit dependencies. While auditing many repositories, it pushes the app sources and its dependencies that may result in duplicate reports.

Closes #66

What is the new behavior?

This PR allows us to ignore all project dependencies.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I made it simple but I think a better way to implement this would be to use an enum like this :

skipDeps?: 'none' | 'implicit' | 'all'

Also, as the getDependentPackagesForProject function is internal, without modifying a bunch of code, I couldn't test the branch properly

@CaporalDead CaporalDead changed the title feat: allow to skip all deps feat: allow to skip all deps (#66) Nov 21, 2024
@CaporalDead CaporalDead changed the title feat: allow to skip all deps (#66) #66 - feat: allow to skip all deps Nov 21, 2024
@devzom
Copy link

devzom commented Dec 18, 2024

Great, looking forward, suggestions seems fine

@MartinNuc-s1
Copy link

Is there any progress on this one? 🙏 We would also appreciate this feature. @koliveira15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analyze independently each project, without their static dependencies

3 participants