feat: add option to skip by path by project name and project type#73
feat: add option to skip by path by project name and project type#73jmvtrinidad wants to merge 7 commits intokoliveira15:mainfrom
Conversation
koliveira15
left a comment
koliveira15
left a comment
There was a problem hiding this comment.
@jmvtrinidad thanks for the contribution! Please fix & address the comments below with a passing build and I will merge
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1bd41c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jmvtrinidad
force-pushed
the
skipPathProjectName
branch
from
482e13e to
2938232
Compare
jmvtrinidad
force-pushed
the
skipPathProjectName
branch
from
2938232 to
571f966
Compare
|
Thanks for reviewing @koliveira15 |
| ) { | ||
| return true; | ||
| } | ||
| return options.skipDependencyTypes.includes( |
There was a problem hiding this comment.
I tested this logic filter in my own repo, and it does not work. It needs to filter by DependencyType.static|implicit|dynamic based on the options array.
"skipDependencyTypes": ["static"]> nx run lib-b:sonar
Included sources paths: libs/lib-a/src,libs/lib-b/src
Included lcov paths: coverage/libs/lib-a/lcov.info,coverage/libs/lib-b/lcov.info| "type": "array", | ||
| "default": [] | ||
| }, | ||
| "skipImplicitDeps": { |
| "type": "string", | ||
| "default": "300" | ||
| }, | ||
| "skipDependencyTypes": { |
There was a problem hiding this comment.
Please update README.md in the root of the project with these properties and remove skipImplicitDeps property from the markdown as well
| ) | ||
| .filter( | ||
| (project) => | ||
| context.projectName === project.name || |
There was a problem hiding this comment.
I tested this logic filter in my own repo, and it does not work as expected
"skipProjects": ["lib-a"]> nx run lib-b:sonar
Included sources paths: libs/lib-a/src,libs/lib-b/src
Included lcov paths: coverage/libs/lib-a/lcov.info,coverage/libs/lib-b/lcov.info| (project) => | ||
| context.projectName === project.name || | ||
| (options.skipPaths?.length | ||
| ? options.skipPaths.some((path) => project.sourceRoot.includes(path)) |
There was a problem hiding this comment.
I tested this logic filter in my own repo, and it does not work as expected
"skipPaths": ["libs/lib-a/src"]> nx run lib-b:sonar
Included sources paths: libs/lib-a/src,libs/lib-b/src
Included lcov paths: coverage/libs/lib-a/lcov.info,coverage/libs/lib-b/lcov.info
jmvtrinidad
force-pushed
the
skipPathProjectName
branch
from
0d0d528 to
e4c0e10
Compare
|
Thanks @koliveira15, I tested it now also with my local, the filter is now working properly |
I have tested this locally and is still not working as expected |
|
@jmvtrinidad are you able to deliver this? :) |
3 participants
No description provided.