Skip to content

Port to Bevy 0.17.#67

Merged
komadori merged 4 commits intomasterfrom
bevy-0.17
Feb 16, 2026
Merged

Port to Bevy 0.17.#67
komadori merged 4 commits intomasterfrom
bevy-0.17

Conversation

@komadori
Copy link
Owner

@komadori komadori commented Sep 3, 2025

No description provided.

@komadori komadori added this to the 0.11 milestone Sep 3, 2025
@komadori komadori marked this pull request as ready for review September 15, 2025 23:08
@coolcatcoder
Copy link

coolcatcoder commented Oct 1, 2025

Trying to update to bevy 0.17, and when trying out this branch, I get a panic.

thread 'main' (117567) panicked at /home/coolcatcoder/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bevy_render-0.17.0/src/render_graph/graph.rs:405:57:
called `Result::unwrap()` on an `Err` value: InvalidNode(Fxaa)

The backtrace tells me that this crate is responsible. Enjoy!

Thanks to the wondrous folks at bevy, I've managed to add a few feature flags to get rid of this error and one more. There are still more problems it seems. I will continue to experiment further in the morning.

Further experimentations has shown that depending on this branch will never work. Forking this branch and depending on that fork, works perfectly. I have no idea why. Consistent at least.

@Sirmadeira
Copy link

@komadori Hello Mr Robin, how are you doing today on this lovely evening. I believe this can be merged. As I personally didnt ran into nay issues

@hannah-computer
Copy link

Thank you for this PR, I just tried it against bevy 0.17.2 in my project and it works as expected :)

Cargo.toml Outdated

[dev-dependencies]
bevy = { version = "0.16.0", default-features = false, features = [
bevy = { version = "0.17.0-rc.1", default-features = false, features = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this (and the one above) be "0.17.0" now that Bevy 0.17 is released?

@taboky-dev
Copy link
Contributor

Hello @komadori, any updates on this?

I tried it against bevy 0.17.3 (which is the last 0.17 version before 0.18) and it works fine. I have local changes porting this to bevy 0.18 starting from this branch.

@Lethja
Copy link
Contributor

Lethja commented Jan 16, 2026

I assume the reason this isn't merged yet is because #65 is still open and marked as part of the 0.11 milestone to.

@komadori komadori merged commit 58e08a2 into master Feb 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants