Skip to content

Unsafe copy memory #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
komamitsu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unsafe copy memory #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd00be4
Update msgpack-java version to 0.7.0
komamitsu Nov 3, 2015
1485bf5
Use Unsafe#copyMemory instead of ByteBuffer#put
komamitsu Nov 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies {
testCompile 'junit:junit:4.11'
testCompile 'ch.qos.logback:logback-classic:1.1.2'
compile 'org.slf4j:slf4j-api:1.7.8'
compile 'org.msgpack:jackson-dataformat-msgpack:0.7.0-M6'
compile 'org.msgpack:jackson-dataformat-msgpack:0.7.0'
compile 'org.komamitsu:phi-accural-failure-detector:0.0.4'
}

Expand Down
37 changes: 36 additions & 1 deletion src/main/java/org/komamitsu/fluency/buffer/PackedForwardBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
import org.msgpack.core.MessagePacker;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import sun.misc.Unsafe;
import sun.nio.ch.DirectBuffer;

import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.lang.reflect.Field;
import java.nio.ByteBuffer;
import java.util.Arrays;
import java.util.HashMap;
Expand All @@ -24,6 +27,23 @@ public class PackedForwardBuffer
private final Map<String, RetentionBuffer> retentionBuffers = new HashMap<String, RetentionBuffer>();
private final LinkedBlockingQueue<TaggableBuffer> flushableBuffers = new LinkedBlockingQueue<TaggableBuffer>();
private final BufferPool bufferPool;
private static final Unsafe unsafe;
static {
Unsafe unsafeInstance = null;
Field f = null;
try {
f = Unsafe.class.getDeclaredField("theUnsafe");
f.setAccessible(true);
unsafeInstance = (Unsafe) f.get(null);
}
catch (NoSuchFieldException e) {
LOG.warn("Failed to get 'theUnsafe'", e);
}
catch (IllegalAccessException e) {
LOG.warn("Failed to get 'theUnsafe'", e);
}
unsafe = unsafeInstance;
}

private PackedForwardBuffer(PackedForwardBuffer.Config bufferConfig)
{
Expand Down Expand Up @@ -58,7 +78,7 @@ private RetentionBuffer prepareBuffer(String tag, int writeSize)
RetentionBuffer newBuffer = new RetentionBuffer(acquiredBuffer);
if (retentionBuffer != null) {
retentionBuffer.getByteBuffer().flip();
newBuffer.getByteBuffer().put(retentionBuffer.getByteBuffer());
copyBuffer(retentionBuffer.getByteBuffer(), newBuffer.getByteBuffer());
bufferPool.returnBuffer(retentionBuffer.getByteBuffer());
}
LOG.trace("prepareBuffer(): allocate a new buffer. tag={}, buffer={}", tag, newBuffer);
Expand All @@ -67,6 +87,21 @@ private RetentionBuffer prepareBuffer(String tag, int writeSize)
return newBuffer;
}

private void copyBuffer(ByteBuffer src, ByteBuffer dst)
{
if (unsafe == null) {
dst.put(src);
}
else {
long srcAddress = ((DirectBuffer) src).address() + src.position();
long dstAddress = ((DirectBuffer) dst).address() + dst.position();
int len = Math.min(src.remaining(), dst.remaining());
unsafe.copyMemory(srcAddress, dstAddress, len);
src.position(src.position() + len);
dst.position(dst.position() + len);
}
}

@Override
public void append(String tag, long timestamp, Map<String, Object> data)
throws IOException
Expand Down