Metal render fixes, make compile MacOS arm64 compatible#177
Open
JoseVarelaP wants to merge 7 commits intokondrak:masterfrom
Open
Metal render fixes, make compile MacOS arm64 compatible#177JoseVarelaP wants to merge 7 commits intokondrak:masterfrom
JoseVarelaP wants to merge 7 commits intokondrak:masterfrom
Conversation
Will build, but won't create a stable MetalView surface for the time being, so it'll crash when making the window.
Now we get in game, with the wrong view size. But I'm getting there!
I say fix, but I need to know if there's a way to get the content scale from the monitor itself, so I don't have to guess it.
It is totally capable of building the game on arm64 with the previous commits.
Deals with multiple things: - Disables strict prototypes - Marks the executables file as always out-of-date so newer versions are always copied over to the output folder. - Dealt with a redefined macro in q_shared.
- Bumped deployment target to macOS 11 given the minimum version of the libvulkan.1.dylib library. - Enabled dead code stripping - Made targets build in parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes updates to the macOS implementation of the Vulkan pipeline for the game, by updating all the calls to current Metal Surface instances, and direct NSWindow scaling.
It also updates the XCode project to allow for arm64 building of the game, allowing for a native Apple Silicon build of the executable (and libraries), and even a universal build with ${ARCHS_STANDARD}.
Do note that the changes do bump the minimum macOS version to 11, given the libvulkan library provided on the Vulkan SDK these days is built against that. The game can be built on a lower version, but to avoid the warning, I made the change.