Use task-runner image as the base image in the source-container-build#403
Draft
fmudry wants to merge 6 commits intokonflux-ci:mainfrom
Draft
Use task-runner image as the base image in the source-container-build#403fmudry wants to merge 6 commits intokonflux-ci:mainfrom
fmudry wants to merge 6 commits intokonflux-ci:mainfrom
Conversation
⛔ Snyk checks have failed. 5 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
fmudry
force-pushed
the
use-task-runner-image-as-base
branch
7 times, most recently
from
7d3b4bc to
1a833c9
Compare
This commit serves just for demonstration, how the solution was tested. Signed-off-by: Filip Mudry <fmudry@redhat.com>
The change from the original base image is that we still need to install the 'file' package, because the BSI script expects it. Moreover, the base image doesn't have 'dnf', but 'microdnf'. Therefore, we need to install 'dnf', because the BSI script needs it. On top of that, the base image has python3.12 instead of python3.11, but that shouldn't be a problem. Signed-off-by: Filip Mudry <fmudry@redhat.com>
TODO Signed-off-by: Filip Mudry <fmudry@redhat.com>
We only need to fetch the 'file' and 'dnf' packages (since they are not included in the task-runner base image and the BSI script expects them). I've replaced ubi9 -> ubi10 in the ubi.repo file, since the task-runner uses ubi10. I've updated the rpms.lock.yaml file using the 'https://github.com/konflux-ci/rpm-lockfile-prototype' tool. Signed-off-by: Filip Mudry <fmudry@redhat.com>
Only formatting changes, because the CI check fails. Signed-off-by: Filip Mudry <fmudry@redhat.com>
fmudry
force-pushed
the
use-task-runner-image-as-base
branch
from
2793c71 to
7606720
Compare
Signed-off-by: Filip Mudry <fmudry@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information, see the commit descriptions.
rpms.lock.yaml file generation
The
rpms.lock.yamlfile was generated using the konflux-ci/rpm-lockfile-prototype tool (copied from the documentation):curl https://raw.githubusercontent.com/konflux-ci/rpm-lockfile-prototype/refs/heads/main/Containerfile \ | podman build -t localhost/rpm-lockfile-prototype -podman run --rm -v ${PWD}:/work:z localhost/rpm-lockfile-prototype:latest --outfile=rpms.lock.yaml ./rpms.in.yamlTesting