Create new namespace pull secret based on namespace pull robot account#267
Open
rcerven wants to merge 1 commit intokonflux-ci:mainfrom
Open
Create new namespace pull secret based on namespace pull robot account#267rcerven wants to merge 1 commit intokonflux-ci:mainfrom
rcerven wants to merge 1 commit intokonflux-ci:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rcerven
force-pushed
the
namespacerobot
branch
3 times, most recently
from
58b370f to
b4b1066
Compare
mmorhun
reviewed
Dec 24, 2025
Member
mmorhun
left a comment
mmorhun
left a comment
There was a problem hiding this comment.
Looks good in general, a few remarks below.
rcerven
force-pushed
the
namespacerobot
branch
5 times, most recently
from
70b2e3c to
4165936
Compare
rcerven
changed the title
rcerven
force-pushed
the
namespacerobot
branch
from
4165936 to
e91dca6
Compare
mmorhun
reviewed
Jan 12, 2026
internal/controller/imagerepository_controller_service_account.go
Outdated
Show resolved
Hide resolved
rcerven
force-pushed
the
namespacerobot
branch
from
e91dca6 to
f0092b5
Compare
mmorhun
reviewed
Jan 13, 2026
rcerven
force-pushed
the
namespacerobot
branch
from
f0092b5 to
2ab1743
Compare
mmorhun
approved these changes
Jan 14, 2026
rcerven
force-pushed
the
namespacerobot
branch
2 times, most recently
from
ceef920 to
3c77615
Compare
Contributor
Author
|
/retest |
8 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
rcerven
force-pushed
the
namespacerobot
branch
2 times, most recently
from
a347ab0 to
831a1f0
Compare
gbenhaim
reviewed
Jan 22, 2026
rcerven
force-pushed
the
namespacerobot
branch
3 times, most recently
from
3261d06 to
378f840
Compare
mmorhun
approved these changes
Jan 29, 2026
rcerven
force-pushed
the
namespacerobot
branch
2 times, most recently
from
c411c35 to
feefe18
Compare
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
rcerven
force-pushed
the
namespacerobot
branch
2 times, most recently
from
bf3f01c to
84945b9
Compare
Contributor
Author
|
@mmorhun we should probably 1st also update application-api in infra-deployments, it shouldn't matter that much for this PR, but doesn't hurt to have the same version which is this PR using |
Contributor
Author
rcerven
force-pushed
the
namespacerobot
branch
3 times, most recently
from
492f527 to
d3370fa
Compare
mmorhun
approved these changes
Feb 11, 2026
Contributor
Author
|
/retest |
rcerven
force-pushed
the
namespacerobot
branch
3 times, most recently
from
2128f52 to
209d0ad
Compare
which is granted read permisssions for all ImageRepositories in the namespace, namespace pull secret is also linked to component build SA and integration SA, new annotation 'image-controller.appstudio.redhat.com/namespace-pull-secret-ensured' is introduced as well, which is set to 'false' after namespace pull secret is created, when missing it will force to create namespace pull robot account and namespace secret, component linking check is based now only on component label, as new model won't have anymore application STONEBLD-4018 Signed-off-by: Robert Cerven <rcerven@redhat.com>
rcerven
force-pushed
the
namespacerobot
branch
from
209d0ad to
5e24efb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is granted read permisssions for all ImageRepositories in the namespace,
namespace pull secret is also linked to component build SA and integration SA,
new annotation
'image-controller.appstudio.redhat.com/ensure-namespace-pull-secret' is introduced as well, which is set to 'false' after namespace pull secret is created,
when set to 'true' it will force to create namespace pull robot account and namespace secret,
component linking check is based now only on component label, as new model won't have anymore application
STONEBLD-4018