inttests/build: make it work with docker#47
Open
chmeliik wants to merge 1 commit intokonflux-ci:mainfrom
Open
Conversation
When running the tests with docker, they fail with
unshare(CLONE_NEWUSER): Operation not permitted
Setting --privileged fixes that. This is not a great solution, because
we don't want to require privileged containers to run kbc image build.
But it's the only one we've found so far. Limit --privileged only to
docker and only to the 'image build' tests so that we still test with
unprivileged containers most of the time.
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
@mmorhun PTAL if this fixes the tests for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the tests with docker, they fail with
Setting --privileged fixes that. This is not a great solution, because we don't want to require privileged containers to run kbc image build. But it's the only one we've found so far. Limit --privileged only to docker and only to the 'image build' tests so that we still test with unprivileged containers most of the time.